Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Add blurb about ABI stability #326

Closed
wants to merge 1 commit into from
Closed

README.md: Add blurb about ABI stability #326

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@gabrielschulhof gabrielschulhof mentioned this pull request Sep 4, 2018
Closed
NickNaso
NickNaso approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Sep 6, 2018
@mhdawson
doc: add blurb about ABI stability
8ed29f5 
PR-URL: #326
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
@mhdawson
Copy link
Member

mhdawson commented Sep 6, 2018

Landed as 8ed29f5

@mhdawson mhdawson closed this Sep 6, 2018
@gabrielschulhof gabrielschulhof deleted the abi-blurb branch December 27, 2018 18:01
@gabrielschulhof gabrielschulhof restored the abi-blurb branch December 28, 2018 20:27
@gabrielschulhof gabrielschulhof deleted the abi-blurb branch February 13, 2019 23:28
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
doc: add blurb about ABI stability
a1b9880 
PR-URL: nodejs/node-addon-api#326
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
doc: add blurb about ABI stability
e9ab999 
PR-URL: nodejs/node-addon-api#326
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
doc: add blurb about ABI stability
e2384ed 
PR-URL: nodejs/node-addon-api#326
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
doc: add blurb about ABI stability
c3e7b2b 
PR-URL: nodejs/node-addon-api#326
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@NickNaso NickNaso NickNaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielschulhof @mhdawson @NickNaso