Fix test failures on linuxOne and AIX #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. This fixes nodejs#230 issue.
|
@mhdawson Could you please trigger the related bots? |
addaleax
approved these changes
Mar 5, 2018
|
Thanks for the quick change, running here: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api/ |
|
Passed on linuxOne, just waiting for free executor on aix for test to run there. |
|
Passed on AIX, going to land in advance of usual 2 day wait as it fixes test regression and I don't think it will be controversial. |
|
landed as 0a2177d |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. Fixes: nodejs/node-addon-api#230 PR-URL: nodejs/node-addon-api#232 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. Fixes: nodejs/node-addon-api#230 PR-URL: nodejs/node-addon-api#232 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. Fixes: nodejs/node-addon-api#230 PR-URL: nodejs/node-addon-api#232 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Currently, the test only considers little endian. So, this patch adds a endian check function(IsLittleEndian()) and then use it instead of hardcoded value. Fixes: nodejs/node-addon-api#230 PR-URL: nodejs/node-addon-api#232 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test only considers little endian. So, this patch adds
a endian check function(IsLittleEndian()) and then use it instead of
hardcoded value.
This fixes #230 issue.