Closed
Conversation
mhdawson
reviewed
Jan 15, 2018
test/objectreference.cc
Outdated
| @@ -0,0 +1,163 @@ | |||
| /* ObjectReference cant be used to create references to Values that | |||
Member
There was a problem hiding this comment.
Should be can as opposed to cant
mhdawson
reviewed
Jan 17, 2018
| assert.equal(rcount, 0); | ||
| binding.objectreference.unrefObjects("weak"); | ||
| }, | ||
| Error |
Member
There was a problem hiding this comment.
If the first 2 asserts are supposed to pass I'm not sure this would catch failures of those asserts ? (Since they throw and overall the assert.throws does not check what Error occured ?
Member
|
I see the following crash after the tests run when this new test is added: If I revert this PR the failure goes away. |
Author
|
@mhdawson when you get a chance, can you check if my recent changes still causes a segfault? Checking on macOS and an ubuntu machine, the segfault no longer occurs. |
mhdawson
pushed a commit
that referenced
this pull request
Jul 30, 2018
PR-URL: #212 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as 4d92a60 |
This was referenced May 2, 2021
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#212 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#212 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#212 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#212 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.