Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for nogc types via BasicEnv #1514

Merged
merged 19 commits into from
Sep 3, 2024
Merged

feat: add support for nogc types via BasicEnv #1514

merged 19 commits into from
Sep 3, 2024

Commits on Aug 2, 2024

  1. src: introduce NogcEnv; support for nogc finalizers

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    d90111f View commit details
    Browse the repository at this point in the history

  2. Address comments in 8 Jun 2024 Node-API meeting: 

    - Use post finalizer to delete reference in `~Reference`
- Remove const ref from comparison operator in `NogcEnv`
- Remove leftover debugging statements
    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1ddf8f0 View commit details
    Browse the repository at this point in the history

  3. sfinae FinalizeData::Wrapper

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    812d27c View commit details
    Browse the repository at this point in the history

  4. fix test/addon_build for experimental

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0ad6fcd View commit details
    Browse the repository at this point in the history

  5. sfinae ObjectWrap::Finalize

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    64392b1 View commit details
    Browse the repository at this point in the history

  6. revert tests

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    18495a4 View commit details
    Browse the repository at this point in the history

  7. add finalizer_order test

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    70a8302 View commit details
    Browse the repository at this point in the history

  8. remove unnecessary defines

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    26972bf View commit details
    Browse the repository at this point in the history

  9. add AddPostFinalizer test

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5d93fc3 View commit details
    Browse the repository at this point in the history

  10. renaming ideas 

    rename NoGcEnv to BasicEnv, AddPostFinalizer to PostFinalizer, NoGc/GcFinalizer to Sync/AsyncFinalizer
    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    94bbe58 View commit details
    Browse the repository at this point in the history

  11. wip on docs for general finalization

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    c4e72eb View commit details
    Browse the repository at this point in the history

  12. switch to "basic" finalizer in docs

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    4e8b367 View commit details
    Browse the repository at this point in the history

  13. Address review comments 

    - Remove discussions about NAPI-EXPERIMENTAL.
    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    de20ac4 View commit details
    Browse the repository at this point in the history

  14. finish renaming async finalizer to basic

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    6ee1ebf View commit details
    Browse the repository at this point in the history

  15. finish docs

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    13118f7 View commit details
    Browse the repository at this point in the history

  16. fix compilation error with duplicate Finalizer identifier

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    1ad6eda View commit details
    Browse the repository at this point in the history

  17. attempt fix compilation issues #2

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    ec9f521 View commit details
    Browse the repository at this point in the history

  18. fix docs

    @KevinEady
    KevinEady committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    a8f6380 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Address review comments

    @KevinEady
    KevinEady committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    195ec28 View commit details
    Browse the repository at this point in the history