src: add Env::GetModuleFileName #1327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*: |
legendecas
reviewed
Jun 13, 2023
| #if NAPI_VERSION > 8 | ||
| inline std::string_view Env::GetModuleFileName() const { | ||
| const char* result; | ||
| napi_status status = node_api_get_module_file_name(_env, &result); |
There was a problem hiding this comment.
Node.js v16.x (and add-ons compiled with the common.gypi shipped with Node.js) is still compiled with C++14, however std::string_view is available since c++17. I think we should avoid using c++17 features here.
There was a problem hiding this comment.
Mhmm mhmm that makes sense ... So then would we prefer the alternative of node-addon-api returning a new std::string by copying the const char* result?
There was a problem hiding this comment.
Would it be good to return the const char* result? If needed, copying the result with std::string is fairly easy.
gabrielschulhof
previously approved these changes
Jun 16, 2023
- Do not use `std::string_view` since not available in C++14 (Node v16)
mhdawson
pushed a commit
that referenced
this pull request
Jun 28, 2023
PR-URL: #1327 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
|
Landed in b83e453 |
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1327 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wrapper for
Napi::Env::GetModuleFileName()from release of Node-API v9.