-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc,chore: drop support for Node.js v14, v19 #1324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KevinEady this looks good to me. We should probably land/create release close together so I'll let you land as part of doing corresponding release. |
@mhdawson would it be beneficial to land the Node-API v9 PRs first prior to the release? This would provide the additional functionality in the next major version: |
@KevinEady I think those will be SemVer minor additions so they can land before/after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds documentation for how to drop support, as well as dropping support for Node.js v14 and v19.
Relates: #1315