Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,chore: drop support for Node.js v14, v19 #1324

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

KevinEady
Copy link
Contributor

Adds documentation for how to drop support, as well as dropping support for Node.js v14 and v19.

Relates: #1315

@KevinEady KevinEady marked this pull request as ready for review June 9, 2023 15:04
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@KevinEady this looks good to me. We should probably land/create release close together so I'll let you land as part of doing corresponding release.

@KevinEady
Copy link
Contributor Author

@mhdawson would it be beneficial to land the Node-API v9 PRs first prior to the release? This would provide the additional functionality in the next major version:

@mhdawson
Copy link
Member

@KevinEady I think those will be SemVer minor additions so they can land before/after.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinEady KevinEady requested a review from vmoroz June 13, 2023 01:10
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit de5c899 into nodejs:main Jun 13, 2023
@KevinEady KevinEady deleted the update-docs-ci-for-release branch June 13, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants