Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add engines limitation into package.json? #1339

Closed
Apollon77 opened this issue Jun 16, 2023 · 2 comments · Fixed by #1340
Closed

Add engines limitation into package.json? #1339

Apollon77 opened this issue Jun 16, 2023 · 2 comments · Fixed by #1340

Comments

@Apollon77
Copy link
Contributor

I just saw 7.0.0 and a changelog note about dropping Node.js 14 and 19 support ... I would have expected that this is also refelected in the package.json but there is no info at all.

Would it not make sense for less issues on developer and user side to have that in the package.json too?
@mhdawson
Copy link
Member

We had a short discussion in the Node-api team meeting today and there was agreement this would be a good addition. Would you like to PR that in?

@Apollon77
Copy link
Contributor Author

Apollon77 commented Jun 16, 2023 •
edited
Loading

Sure, I will do in text days ... ok was faster ... PR is there

@Apollon77 Apollon77 mentioned this issue Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Node.js version restrictions Apollon77/node-addon-api
2 participants
@mhdawson @Apollon77