Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for working with Promises #126

Closed
koistya opened this issue Sep 2, 2017 · 6 comments
Closed

Add API for working with Promises #126

koistya opened this issue Sep 2, 2017 · 6 comments

Comments

@koistya
Copy link
Contributor

koistya commented Sep 2, 2017

How hard would it be to implement APIs allowing writing Promise-based N-API addons?

@jasongin
Copy link
Member

jasongin commented Sep 3, 2017

A C API for promises was just recently implemented at nodejs/node#14365

Now it definitely makes sense to expose that in the C++ wrapper. @gabrielschulhof are you planning to do that? Otherwise I might get to it eventually. Or someone else interested may pick it up.

@JamesMGreene
Copy link

This issue should be closed now.

@koistya
Copy link
Contributor Author

koistya commented Nov 5, 2017

@JamesMGreene It would be great to have some docs/examples (/doc/promises.md)

@NickNaso
Copy link
Member

NickNaso commented Nov 5, 2017

@koistya We are working on documentation. What do you think if we add the example or the references to the examples inside the documentation?

@NickNaso
Copy link
Member

Hi @koistya,
now we documented the promise api https://github.com/nodejs/node-addon-api/blob/master/doc/promises.md
What do you think should we close this issue?

@NickNaso
Copy link
Member

NickNaso commented Sep 7, 2018

I'm closing the issue because now the API to work with Promise has been added and documented.

@NickNaso NickNaso closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants