Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI seems to have a breaking change #1133

Closed
JckXia opened this issue Feb 17, 2022 · 4 comments
Closed

CI seems to have a breaking change #1133

JckXia opened this issue Feb 17, 2022 · 4 comments

Comments

@JckXia
Copy link
Member

JckXia commented Feb 17, 2022

It looks our windows ci pipeline is breaking. (https://github.com/nodejs/node-addon-api/runs/5234233924?check_suite_focus=true, https://github.com/nodejs/node-addon-api/runs/5238788474?check_suite_focus=true). I think it has to do with windows-latest no longer pointing to windows-2019 but windows-2022 instead.

https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/
@NickNaso
Copy link
Member

Hi @JckXia,
I think that the main problem is in node-gyp see: nodejs/node-gyp#2552 and when this issue will be resolved we could use the windows-latest or winrdows-2022. See: actions/runner-images#4856

@JckXia
Copy link
Member Author

JckXia commented Feb 17, 2022

@NickNaso Yep that looks it. I guess for now we could roll back to windows-2019 as a stop gap?

@NickNaso
Copy link
Member

I agree with you and I already approved your PR #1132

@JckXia
Copy link
Member Author

JckXia commented Feb 17, 2022

Awesome. Thanks @NickNaso !

@JckXia JckXia closed this as completed Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NickNaso @JckXia