Skip to content

Commit fa3a615

Browse files
romandevmhdawson
authored andcommitted
src: use MakeCallback() -> Call() in AsyncWorker
Change `AsyncWorker::OnOK()` and `AsyncWorker::OnError()` callbacks to **NOT** use `MakeCallback()`. An ordinary function call (`_callback::Call()`) is now correct. PR-URL: #361 Refs: https://nodejs.org/api/n-api.html#n_api_napi_make_callback Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@NickNaso.local>
1 parent 2342415 commit fa3a615

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

napi-inl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3588,11 +3588,11 @@ inline FunctionReference& AsyncWorker::Callback() {
35883588
}
35893589

35903590
inline void AsyncWorker::OnOK() {
3591-
_callback.MakeCallback(_receiver.Value(), std::initializer_list<napi_value>{});
3591+
_callback.Call(_receiver.Value(), std::initializer_list<napi_value>{});
35923592
}
35933593

35943594
inline void AsyncWorker::OnError(const Error& e) {
3595-
_callback.MakeCallback(_receiver.Value(), std::initializer_list<napi_value>{ e.Value() });
3595+
_callback.Call(_receiver.Value(), std::initializer_list<napi_value>{ e.Value() });
35963596
}
35973597

35983598
inline void AsyncWorker::SetError(const std::string& error) {

0 commit comments

Comments
 (0)