fix: git-clang-format doesn't recognize no changes requested on given files (#835)

Author: legendecas

package.json

@@ -303,7 +303,7 @@
     "predev:incremental": "node-gyp configure build -C test --debug",
     "dev:incremental": "node test",
     "doc": "doxygen doc/Doxyfile",
-    "lint": "node scripts/clang-format.js",
+    "lint": "node tools/clang-format.js",
     "lint:fix": "git-clang-format"
   },
   "pre-commit": "lint",

tools/README.md

@@ -1,4 +1,10 @@
-# Migration Script
+# Tools
+
+## clang-format
+
+The clang-format checking tools is designed to check changed lines of code compared to given git-refs.
+
+## Migration Script
 
 The migration tool is designed to reduce repetitive work in the migration process. However, the script is not aiming to convert every thing for you. There are usually some small fixes and major reconstruction required.
 

scripts/clang-format.js renamed to tools/clang-format.js

@@ -27,7 +27,8 @@ function main(args) {
   }
 
   const clangFormatOutput = result.stdout.trim();
-  if (clangFormatOutput !== ('no modified files to format') &&
+  if (clangFormatOutput !== '' &&
+      clangFormatOutput !== ('no modified files to format') &&
       clangFormatOutput !== ('clang-format did not modify any files')) {
     console.error(clangFormatOutput);
     const fixCmd = '"npm run lint:fix"';