Add String/Symbol::New with string view unit tests

Author: cacharle

test/name.cc

@@ -1,5 +1,9 @@
 #include "napi.h"
 
+#if __cplusplus >= 201703L
+#include <string_view>
+#endif
+
 using namespace Napi;
 
 const char* testValueUtf8 = "123456789";
@@ -43,6 +47,12 @@ Value CreateString(const CallbackInfo& info) {
   }
 }
 
+#if __cplusplus >= 201703L
+Value CreateStringFromStringView(const CallbackInfo& info) {
+  return String::New(info.Env(), std::string_view("hello1"));
+}
+#endif
+
 Value CheckString(const CallbackInfo& info) {
   String value = info[0].As<String>();
   String encoding = info[1].As<String>();
@@ -80,6 +90,12 @@ Value CreateSymbol(const CallbackInfo& info) {
   }
 }
 
+#if __cplusplus >= 201703L
+Value CreateSymbolFromStringView(const CallbackInfo& info) {
+  return Symbol::New(info.Env(), std::string_view("hello2"));
+}
+#endif
+
 Value CheckSymbol(const CallbackInfo& info) {
   return Boolean::New(info.Env(), info[0].Type() == napi_symbol);
 }
@@ -99,11 +115,13 @@ Object InitName(Env env) {
 
   exports["echoString"] = Function::New(env, EchoString);
   exports["createString"] = Function::New(env, CreateString);
+  exports["createStringFromStringView"] = Function::New(env, CreateStringFromStringView);
   exports["nullStringShouldThrow"] = Function::New(env, NullStringShouldThrow);
   exports["nullString16ShouldThrow"] =
       Function::New(env, NullString16ShouldThrow);
   exports["checkString"] = Function::New(env, CheckString);
   exports["createSymbol"] = Function::New(env, CreateSymbol);
+  exports["CreateSymbolFromStringView"] = Function::New(env, CreateSymbolFromStringView);
   exports["checkSymbol"] = Function::New(env, CheckSymbol);
 
   return exports;

test/name.js

@@ -56,4 +56,7 @@ function test (binding) {
     assert.strictEqual(binding.name.echoString(str, 'utf8'), str);
     assert.strictEqual(binding.name.echoString(str, 'utf16'), str);
   }
+
+  assert.strictEqual(binding.name.createStringFromStringView(), "hello1")
+  assert.strictEqual(binding.name.createSymbolFromStringView(), "hello2")
 }