Skip to content

Commit 0eda0d6

Browse files
author
Sampson Gao
committed
Add missing error handling check in CallbackInfo::NewTarget()
1 parent f894a43 commit 0eda0d6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

napi-inl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2018,15 +2018,15 @@ inline CallbackInfo::~CallbackInfo() {
20182018
inline Value CallbackInfo::NewTarget() const {
20192019
napi_value newTarget;
20202020
napi_status status = napi_get_new_target(_env, _info, &newTarget);
2021+
NAPI_THROW_IF_FAILED(_env, status, Value());
20212022
return Value(_env, newTarget);
20222023
}
20232024

20242025
inline bool CallbackInfo::IsConstructCall() const {
20252026
napi_value newTarget;
20262027
napi_status status = napi_get_new_target(_env, _info, &newTarget);
2027-
bool isConstructCall = (new_target != nullptr);
20282028
NAPI_THROW_IF_FAILED(_env, status, false);
2029-
return isConstructCall;
2029+
return (new_target != nullptr);
20302030
}
20312031

20322032
inline Napi::Env CallbackInfo::Env() const {

0 commit comments

Comments
 (0)