Skip to content

Remove BoringSSL dh-primes addition #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove BoringSSL dh-primes addition #5

merged 1 commit into from
Feb 13, 2025

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Feb 13, 2025

I don't believe these are necessary for current versions of BoringSSL.

The added functions:

  • BN_get_rfc3526_prime_2048
  • BN_get_rfc3526_prime_3072
  • BN_get_rfc3526_prime_4096
  • BN_get_rfc3526_prime_6144
  • BN_get_rfc3526_prime_8192

can be found here and were added in https://boringssl-review.googlesource.com/c/boringssl/+/54305

Electron compiles without this file without issue.

@codebytere codebytere mentioned this pull request Feb 13, 2025
Merged
@jasnell jasnell merged commit c2a9093 into nodejs:main Feb 13, 2025
10 checks passed
jasnell added a commit that referenced this pull request Feb 13, 2025
@jasnell
Revert "Remove BoringSSL dh-primes addition (#5)"
7ddf64a 
This reverts commit c2a9093.
jasnell added a commit that referenced this pull request Feb 14, 2025
@jasnell
Conditional defines to support older boringssl+fips configurations (#6)
134ac40 
* Older boringssl versions do not have the kdf.h header

* Revert "Remove BoringSSL dh-primes addition (#5)"

This reverts commit c2a9093.

* Avoid use of BN_GENCB_get_arg

API is not defined in older versions of openssl and boringssl

* More support for older boringssl+fips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codebytere @jasnell