Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-05-23 meeting notes #143

Merged
merged 2 commits into from
May 29, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions doc/meetings/2023-05-23.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Node.js Loaders Team Meeting 2023-05-23

## Links

* **Recording**: https://www.youtube.com/watch?v=JAwwmD77vC4
* **GitHub Issue**: https://github.com/nodejs/loaders/issues/141

## Present

* Loaders team: @nodejs/loaders
* Antoine du Hamel @aduh95
* Geoffrey Booth @GeoffreyBooth
* Isaac Schlueter @isaacs
* Jacob Smith @JakobJingleheimer


## Notes

### https://github.com/nodejs/node/pull/46826 `registerLoader()`

- Whether to deprecate/remove `--loader` flag. Something we might consider after landing `registerLoader`, to simplify overall API. (Loaders can just tell their users to swap `--loader` for `--import`).

- Align name on `register`, so `import { register } from 'node:module'` for what’s currently called `registerLoader`, to provide a standard namespace for registering customization hooks for various APIs. For example, in the future:

```js
import { register as moduleRegister } from 'node:module';
import { register as fsRegister } from 'node:fs';
```

- Ensure there is a test-case for missing `--loader` flag (assert error thrown) until the follow-up where we remove that limitation. We should hold the first PR from being released until the follow-up also lands.

- Jacob to handle follow-up (reunite ESMLoader classes) ~next week

### https://github.com/nodejs/node/pull/47999 `handle CJS via ESMLoader`

- Isaac to help with test-cases

- Jacob to help after `registerLoader` follow-up