Stricter parsing of status line#217
Merged
ShogunPanda merged 1 commit intonodejs:mainfrom Feb 9, 2023
Merged
Conversation
ShogunPanda
reviewed
Jan 18, 2023
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stricter parsing of status line
Background:
llhttp currently does not handle extra spaces in the status line correctly
This snippet:
HTTP/1.1 200 OKIs parsed as status=0, v=1/1, reason =
' OK', which is clearly not correct.This PR rejects a status line with more than one space between HTTP version and status code, and also requires that the status code is exactly 3 digits as per the relevant section on RFC7230 which says that a status line is: