-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom / non-standard methods and request/response lines #11
Comments
Regardless of anything specific that exists now, it would certainly be nice to have this flexibility. Would a PR be accepted if one was submitted? |
Given how llhttp is currently implemented, this cannot be easily done at runtime. We will be happy to accept patches to added new methods but this cannot be left to the user. Closing this. |
@ShogunPanda why not leave it open, then? It would signal that a PR would indeed be accepted. |
Well, I closed because with the current code structure that cannot be done without significantly changing the parser. Therefore the issue is closed. Any PR will be accepted, reviewed and eventually merged. |
But if the codebase doesn't allow itself to do this, wouldn't that mean a PR would be closed? Corollary, would a PR that signficantly changed the parser be accepted? |
The latter. If somebody instead will send that drastic PR, then it would certainly be evaluated. |
If something in #54 could be useful, I can work to rebase it on the current version The patch itself changed the parser and allowed custom protocol and methods, but was rejected at the time |
Thanks for refreshing the parser, it was really a hard-to-extend project. Now it is more modifiable, how about adding some flexibility? Would be very handy to use this parser for custom HTTP-like protocols that utilize different request/response lines but seem similar in other aspects. F.ex., RTSP. If the parser would allow such inputs when it has, say, property
customAllowed
==true
, it'd be very useful and would simplify handling these protocols a lotThe text was updated successfully, but these errors were encountered: