Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom / non-standard methods and request/response lines #11

Closed
Fr0sT-Brutal opened this issue Dec 11, 2018 · 8 comments
Closed

Custom / non-standard methods and request/response lines #11

Fr0sT-Brutal opened this issue Dec 11, 2018 · 8 comments
Labels
enhancement New feature or request

Comments

@Fr0sT-Brutal
Copy link

Fr0sT-Brutal commented Dec 11, 2018

Thanks for refreshing the parser, it was really a hard-to-extend project. Now it is more modifiable, how about adding some flexibility? Would be very handy to use this parser for custom HTTP-like protocols that utilize different request/response lines but seem similar in other aspects. F.ex., RTSP. If the parser would allow such inputs when it has, say, property customAllowed == true, it'd be very useful and would simplify handling these protocols a lot

@pallas
Copy link
Contributor

pallas commented Nov 6, 2020

To follow up, note 0b0772c & 07edcd2, which added RTSP/RAOP.

@Qix-
Copy link

Qix- commented Oct 27, 2021

Regardless of anything specific that exists now, it would certainly be nice to have this flexibility. Would a PR be accepted if one was submitted?

@ShogunPanda
Copy link
Contributor

Given how llhttp is currently implemented, this cannot be easily done at runtime. We will be happy to accept patches to added new methods but this cannot be left to the user. Closing this.

@ShogunPanda ShogunPanda closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2022
@Qix-
Copy link

Qix- commented Aug 22, 2022

@ShogunPanda why not leave it open, then? It would signal that a PR would indeed be accepted.

@ShogunPanda
Copy link
Contributor

Well, I closed because with the current code structure that cannot be done without significantly changing the parser.

Therefore the issue is closed.

Any PR will be accepted, reviewed and eventually merged.

@Qix-
Copy link

Qix- commented Aug 22, 2022

But if the codebase doesn't allow itself to do this, wouldn't that mean a PR would be closed? Corollary, would a PR that signficantly changed the parser be accepted?

@ShogunPanda
Copy link
Contributor

The latter.
We have no bandwidth to do this at the moment, so we closed the issue.

If somebody instead will send that drastic PR, then it would certainly be evaluated.

@alekitto
Copy link

If something in #54 could be useful, I can work to rebase it on the current version

The patch itself changed the parser and allowed custom protocol and methods, but was rejected at the time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants