http2: var to const/let

Author: sebdeckers

lib/internal/http2/compat.js

@@ -46,29 +46,29 @@ function isPseudoHeader(name) {
 }
 
 function onStreamData(chunk) {
-  var request = this[kRequest];
+  const request = this[kRequest];
   if (!request.push(chunk))
     this.pause();
 }
 
 function onStreamEnd() {
   // Cause the request stream to end as well.
-  var request = this[kRequest];
+  const request = this[kRequest];
   request.push(null);
 }
 
 function onStreamError(error) {
-  var request = this[kRequest];
+  const request = this[kRequest];
   request.emit('error', error);
 }
 
 function onRequestPause() {
-  var stream = this[kStream];
+  const stream = this[kStream];
   stream.pause();
 }
 
 function onRequestResume() {
-  var stream = this[kStream];
+  const stream = this[kStream];
   stream.resume();
 }
 
@@ -78,22 +78,22 @@ function onRequestDrain() {
 }
 
 function onStreamResponseDrain() {
-  var response = this[kResponse];
+  const response = this[kResponse];
   response.emit('drain');
 }
 
 function onStreamResponseError(error) {
-  var response = this[kResponse];
+  const response = this[kResponse];
   response.emit('error', error);
 }
 
 function onStreamClosedRequest() {
-  var req = this[kRequest];
+  const req = this[kRequest];
   req.push(null);
 }
 
 function onStreamClosedResponse() {
-  var res = this[kResponse];
+  const res = this[kResponse];
   res.writable = false;
   res.emit('finish');
 }
@@ -133,12 +133,12 @@ class Http2ServerRequest extends Readable {
   }
 
   get closed() {
-    var state = this[kState];
+    const state = this[kState];
     return Boolean(state.closed);
   }
 
   get code() {
-    var state = this[kState];
+    const state = this[kState];
     return Number(state.closedCode);
   }
 
@@ -155,11 +155,11 @@ class Http2ServerRequest extends Readable {
   }
 
   get rawHeaders() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return [];
-    var tuples = Object.entries(headers);
-    var flattened = Array.prototype.concat.apply([], tuples);
+    const tuples = Object.entries(headers);
+    const flattened = Array.prototype.concat.apply([], tuples);
     return flattened.map(String);
   }
 
@@ -188,7 +188,7 @@ class Http2ServerRequest extends Readable {
   }
 
   _read(nread) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream) {
       stream.resume();
     } else {
@@ -197,21 +197,21 @@ class Http2ServerRequest extends Readable {
   }
 
   get method() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     return headers[constants.HTTP2_HEADER_METHOD];
   }
 
   get authority() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     return headers[constants.HTTP2_HEADER_AUTHORITY];
   }
 
   get scheme() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     return headers[constants.HTTP2_HEADER_SCHEME];
@@ -226,27 +226,27 @@ class Http2ServerRequest extends Readable {
   }
 
   get path() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     return headers[constants.HTTP2_HEADER_PATH];
   }
 
   set path(path) {
-    var headers = this[kHeaders];
+    let headers = this[kHeaders];
     if (headers === undefined)
       headers = this[kHeaders] = Object.create(null);
     headers[constants.HTTP2_HEADER_PATH] = path;
   }
 
   setTimeout(msecs, callback) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream === undefined) return;
     stream.setTimeout(msecs, callback);
   }
 
   [kFinish](code) {
-    var state = this[kState];
+    const state = this[kState];
     if (state.closed)
       return;
     state.closedCode = code;
@@ -280,17 +280,17 @@ class Http2ServerResponse extends Stream {
   }
 
   get finished() {
-    var stream = this[kStream];
+    const stream = this[kStream];
     return stream === undefined || stream._writableState.ended;
   }
 
   get closed() {
-    var state = this[kState];
+    const state = this[kState];
     return Boolean(state.closed);
   }
 
   get code() {
-    var state = this[kState];
+    const state = this[kState];
     return Number(state.closedCode);
   }
 
@@ -299,7 +299,7 @@ class Http2ServerResponse extends Stream {
   }
 
   get headersSent() {
-    var stream = this[kStream];
+    const stream = this[kStream];
     return stream.headersSent;
   }
 
@@ -316,7 +316,7 @@ class Http2ServerResponse extends Stream {
   }
 
   set statusCode(code) {
-    var state = this[kState];
+    const state = this[kState];
     code |= 0;
     if (code >= 100 && code < 200)
       throw new errors.RangeError('ERR_HTTP2_INFO_STATUS_NOT_ALLOWED');
@@ -326,51 +326,51 @@ class Http2ServerResponse extends Stream {
   }
 
   addTrailers(headers) {
-    var trailers = this[kTrailers];
-    var keys = Object.keys(headers);
-    var key = '';
+    let trailers = this[kTrailers];
+    const keys = Object.keys(headers);
+    let key = '';
     if (keys.length > 0)
       return;
     if (trailers === undefined)
       trailers = this[kTrailers] = Object.create(null);
     for (var i = 0; i < keys.length; i++) {
       key = String(keys[i]).trim().toLowerCase();
-      var value = headers[key];
+      const value = headers[key];
       assertValidHeader(key, value);
       trailers[key] = String(value);
     }
   }
 
   getHeader(name) {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     name = String(name).trim().toLowerCase();
     return headers[name];
   }
 
   getHeaderNames() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return [];
     return Object.keys(headers);
   }
 
   getHeaders() {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     return Object.assign({}, headers);
   }
 
   hasHeader(name) {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return false;
     name = String(name).trim().toLowerCase();
     return Object.prototype.hasOwnProperty.call(headers, name);
   }
 
   removeHeader(name) {
-    var headers = this[kHeaders];
+    const headers = this[kHeaders];
     if (headers === undefined)
       return;
     name = String(name).trim().toLowerCase();
@@ -380,7 +380,7 @@ class Http2ServerResponse extends Stream {
   setHeader(name, value) {
     name = String(name).trim().toLowerCase();
     assertValidHeader(name, value);
-    var headers = this[kHeaders];
+    let headers = this[kHeaders];
     if (headers === undefined)
       headers = this[kHeaders] = Object.create(null);
     headers[name] = String(value);
@@ -403,8 +403,8 @@ class Http2ServerResponse extends Stream {
       headers = statusMessage;
     }
     if (headers) {
-      var keys = Object.keys(headers);
-      var key = '';
+      const keys = Object.keys(headers);
+      let key = '';
       for (var i = 0; i < keys.length; i++) {
         key = keys[i];
         this.setHeader(key, headers[key]);
@@ -414,15 +414,15 @@ class Http2ServerResponse extends Stream {
   }
 
   write(chunk, encoding, cb) {
-    var stream = this[kStream];
+    const stream = this[kStream];
 
     if (typeof encoding === 'function') {
       cb = encoding;
       encoding = 'utf8';
     }
 
     if (stream === undefined) {
-      var err = new errors.Error('ERR_HTTP2_STREAM_CLOSED');
+      const err = new errors.Error('ERR_HTTP2_STREAM_CLOSED');
       if (cb)
         process.nextTick(cb, err);
       else
@@ -434,7 +434,7 @@ class Http2ServerResponse extends Stream {
   }
 
   end(chunk, encoding, cb) {
-    var stream = this[kStream];
+    const stream = this[kStream];
 
     if (typeof chunk === 'function') {
       cb = chunk;
@@ -460,7 +460,7 @@ class Http2ServerResponse extends Stream {
   }
 
   destroy(err) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream === undefined) {
       // nothing to do, already closed
       return;
@@ -469,7 +469,7 @@ class Http2ServerResponse extends Stream {
   }
 
   setTimeout(msecs, callback) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream === undefined) return;
     stream.setTimeout(msecs, callback);
   }
@@ -479,7 +479,7 @@ class Http2ServerResponse extends Stream {
   }
 
   sendInfo(code, headers) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream.headersSent === true) {
       throw new errors.Error('ERR_HTTP2_INFO_HEADERS_AFTER_RESPOND');
     }
@@ -495,12 +495,12 @@ class Http2ServerResponse extends Stream {
   }
 
   createPushResponse(headers, callback) {
-    var stream = this[kStream];
+    const stream = this[kStream];
     if (stream === undefined) {
       throw new errors.Error('ERR_HTTP2_STREAM_CLOSED');
     }
     stream.pushStream(headers, {}, function(stream, headers, options) {
-      var response = new Http2ServerResponse(stream);
+      const response = new Http2ServerResponse(stream);
       callback(null, response);
     });
   }
@@ -520,7 +520,7 @@ class Http2ServerResponse extends Stream {
   }
 
   [kFinish](code) {
-    var state = this[kState];
+    const state = this[kState];
     if (state.closed)
       return;
     state.closedCode = code;
@@ -532,12 +532,12 @@ class Http2ServerResponse extends Stream {
 }
 
 function onServerStream(stream, headers, flags) {
-  var server = this;
-  var request = new Http2ServerRequest(stream, headers);
-  var response = new Http2ServerResponse(stream);
+  const server = this;
+  const request = new Http2ServerRequest(stream, headers);
+  const response = new Http2ServerResponse(stream);
 
   // Check for the CONNECT method
-  var method = headers[constants.HTTP2_HEADER_METHOD];
+  const method = headers[constants.HTTP2_HEADER_METHOD];
   if (method === 'CONNECT') {
     if (!server.emit('connect', request, response)) {
       response.statusCode = constants.HTTP_STATUS_METHOD_NOT_ALLOWED;