fix: add quotes for command in msvs generator#217
Merged
targos merged 1 commit intonodejs:mainfrom Oct 25, 2023
Merged
Conversation
The msvs generator only added quotes for arguments of the action, the command itself should have quotes too. Without this change actions will fail when python binary is placed in a path with spaces in it.
gengjiawen
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The msvs generator only added quotes for arguments of the action, the command itself should have quotes too.
Without this change actions will fail when python binary is placed in a path with spaces in it.
Refs nodejs/node#48462.
/cc @gengjiawen