chore (main): vendor in Python packaging for Py3.12#214
Conversation
rzhao271
left a comment
There was a problem hiding this comment.
Do we still need line 15 in the TOML file?
The line that says dependencies = ["packaging>=23.1"]
|
I think for open source license compliance, |
|
|
This PR worked for me! The details of my testing are posted below, for anyone who is curious. Test method:
Confirming this fix was needed (Testing the "null hypothesis"):
Main Result (This PR Fixes the Errors):
|
|
I confirm that macOS homebrew's |
`node-gyp` already resolved python `setuptools` dependency by vendor in the `packaging` package, as described [here](nodejs/gyp-next#214), last year and released `node-gyp` v10 containing this fix this March (see [here](nodejs/node-gyp#2869 (comment))). But true, without `python-distutils-extra`, `makepkg` will fail with `node-gyp` not found.
Adds support for Python 3.12+ See nodejs/gyp-next#214
Fixes #211
Fixes #213
Related to:
distutilslibrary node-gyp#28883.11.6Missingdistutilsmodule node-gyp#2915distutilswas removed in Python 3.12 and the Python Packaging Authority recommends usingpackaginginstead.Let's vendor in
packagingso that installingnode-gypdoes not require runningpip install packaging.@rzhao271 @DeeDeeG @StefanStojanovic @brjsp