-
Notifications
You must be signed in to change notification settings - Fork 73
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add VCToolsVersion for msvs (#209)
* Add the ability to specify the 'MSVC toolset version' <VCToolsVersion> for the VisualStudio platform. Usage example for binding.gyp ``` 'targets': [ { 'configurations': { 'Debug': { "msvs_configuration_attributes": { "VCToolsVersion": "14.36.32532", ``` * chore: update build-windows runs-on to windows-latest extract from comments by PR #209:add VCToolsVersion for msvs ``` The Node.js Windows integration / build-windows workflow runs on windows-2019 which from what I know uses VS2019. However, after this landed in Node.js, it no longer supports building on VS2019 and requires VS2022. Luckily for us, fix should be as simple as changing the line I referenced in a workflow file to windows-2022 or even simpler to windows-latest. ```
- Loading branch information
1 parent
98da389
commit 0e35ab8
Showing
3 changed files
with
11 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters