From 0911664f99f648399bf961e684cc8445c18aed40 Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Sun, 3 May 2020 20:06:32 +0530 Subject: [PATCH] fix windows bug (#37) Refs: https://chromium.googlesource.com/external/gyp/+/ab4aca868d68b9de9b20a9991bbbb5e78ab48a30 Refs: https://github.com/nodejs/node/pull/32698#discussion_r405540105 --- pylib/gyp/common.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pylib/gyp/common.py b/pylib/gyp/common.py index 3f2329bd..bfe546f8 100644 --- a/pylib/gyp/common.py +++ b/pylib/gyp/common.py @@ -364,7 +364,7 @@ def __init__(self): dir=base_temp_dir, ) try: - self.tmp_file = os.fdopen(tmp_fd, "w") + self.tmp_file = os.fdopen(tmp_fd, "wb") except Exception: # Don't leave turds behind. os.unlink(self.tmp_path)