Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Cpp Refactoring Ensuring avoiding duplicate package cache #58

Closed
wants to merge 1 commit into from
Closed

Cpp Refactoring Ensuring avoiding duplicate package cache #58

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

This brings through the refactorings from #57 that avoid cache duplication and should improve performance, described in detail there, while retaining the current behaviour of having the --type flag only apply to the entry point file and not any other files in the entry point scope.

@guybedford guybedford force-pushed the cppformat branch 2 times, most recently from e59148d to b6baba4 Compare March 10, 2019 18:13
ljharb
ljharb approved these changes Mar 10, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t review the cpp, but I’m trusting that this PR doesn’t change observable behavior and that the docs are improved :-)

@MylesBorins MylesBorins mentioned this pull request Mar 13, 2019
Closed
@guybedford guybedford force-pushed the cppformat branch 2 times, most recently from 2a3f448 to 4d25173 Compare March 13, 2019 20:52
@MylesBorins
Copy link
Contributor

landed in c894000

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ljharb ljharb ljharb approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
modules-agenda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guybedford @MylesBorins @ljharb @GeoffreyBooth