Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

CI fixes for latest commits and reland #45 #49

Merged
merged 15 commits into from
Mar 5, 2019

Conversation

guybedford
Copy link
Contributor

This fixes up some linting issues that crept in on the last merges.

@guybedford
Copy link
Contributor Author

guybedford commented Mar 5, 2019

@MylesBorins
Copy link
Contributor

Some failures...

sequential/test-child-process-fork-getconnections on alpine-last-latest-x64.. I think that might be a flake

test.es-module/test-esm-symlink-type on windows

AssertionError [ERR_ASSERTION]: For {"source":"extensionless-symlink-to-mjs-file","prints":".mjs file","errorsWithPreserveSymlinksMain":false}, errored unexpectedly with --preserve-symlinks-main
    at common.mustCall (c:\workspace\node-test-binary-windows\test\es-module\test-esm-symlink-type.js:56:18)
    at c:\workspace\node-test-binary-windows\test\common\index.js:367:15
    at ChildProcess.exithandler (child_process.js:302:5)
    at ChildProcess.emit (events.js:198:13)
    at maybeClose (internal/child_process.js:984:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:265:5)

@MylesBorins MylesBorins changed the title CI fixes for latest commits CI fixes for latest commits and reland #45 Mar 5, 2019
@MylesBorins
Copy link
Contributor

We've ended up reverted #45 temporarily and moving it into this PR in an attempt to get CI green. We should like land as a single commit after we get it working

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 5, 2019

CI of modules-lkgr for comparison: https://ci.nodejs.org/job/node-test-commit/26377/

@MylesBorins
Copy link
Contributor

hmmm I'm actually seeing a bunch more failures on LKGR before that other Pr... fun!

I'm going to go ahead and land this as it is

@guybedford lets dig into and try to find the windows fix independently and worry about making the branch release ready later

@MylesBorins MylesBorins merged commit 49a38bb into nodejs:modules-lkgr Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants