This repository was archived by the owner on Apr 16, 2020. It is now read-only.
modules: remove file extension and directory resolving for esm#2
Closed
MylesBorins wants to merge 1 commit intomasterfrom
Closed
modules: remove file extension and directory resolving for esm#2MylesBorins wants to merge 1 commit intomasterfrom
MylesBorins wants to merge 1 commit intomasterfrom
Conversation
Member
|
i'd like to make sure we have this repo set up to automatically pull updates from nodejs/node before we're merging changes |
Member
|
We have people discussing the continues use of bundlers in #1 and not focusing on web compatibility since they can continue to use the solutions bundlers provide. If that is the mentality we don't need to do this PR since resolution could be provided by ahead of time tools like bundlers. Additionally, given the package name maps approach and proof of creating maps that support index files, extension completion, etc. I don't see the need for this PR even with people wanting to use bundlers if they want to manually make package name maps, or using a different tool. |
This was referenced Aug 28, 2018
this build on top of the limitations of the package name map proposal. It removes file extensions and directory resolution in the resolver. This is only currently limited for local development. When resolving dependencies file extension and directory resolution will still work. Refs: https://github.com/domenic/package-name-maps
c00412d to
2ace497
Compare
This was referenced Sep 12, 2018
Merged
Contributor
Author
|
Closing in lieu of #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this build on top of the limitations of the package name map proposal.
It removes file extensions and directory resolution in the resolver.
This is only currently limited for local development. When resolving
dependencies file extension and directory resolution will still work.
Refs: https://github.com/domenic/package-name-maps
Moved from nodejs/node#21729
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes