Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alpine in node@8 to 3.6 #413

Merged
merged 1 commit into from
May 31, 2017
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 31, 2017

Just 8.0, right?

This does not update Dockerfile-alpine.template, which means running update.sh will rollback the version in this dockerfile. Is that expected/wanted?

This was referenced May 31, 2017
Starefossen

This comment was marked as off-topic.

@Starefossen
Copy link
Member

All green build in Travis: https://travis-ci.org/nodejs/docker-node/builds/237802125

@pesho
Copy link
Contributor

pesho commented May 31, 2017

This does not update Dockerfile-alpine.template, which means running update.sh will rollback the version in this dockerfile. Is that expected/wanted?

For the record (personal opinion, not WG policy) - the template should be updated, and update.sh without parameters should not be used, but only run with a specific version, like update.sh 8.0.

@SimenB
Copy link
Member Author

SimenB commented May 31, 2017

If the template is updated, that would mean node 4 and 6 would get the new alpine version.

@SimenB SimenB deleted the node-8-alpine-3.6 branch May 31, 2017 10:36
@pesho
Copy link
Contributor

pesho commented May 31, 2017

If the template is updated, that would mean node 4 and 6 would get the new alpine version.

When they see new releases, yes, that's a weakness in the current setup. They would require manual cleanup after update.sh then. Either that, or the current branch (8.x) would require manual fixing (present state). I think the better option is if the template matches the current branch, as it would see more frequent releases from now on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants