chore: Use openpgp and Ubuntu keyservers#1510
Conversation
| #!/bin/sh -ex | ||
|
|
||
| curl -fsSLo- --compressed https://github.com/nodejs/node/raw/master/README.md | awk '/^gpg --keyserver pool.sks-keyservers.net --recv-keys/ {print $NF}' > keys/node.keys | ||
| curl -fsSLo- --compressed https://github.com/nodejs/node/raw/master/README.md | awk '/^gpg --keyserver hkps://keys.openpgp.org --recv-keys/ {print $NF}' > keys/node.keys |
There was a problem hiding this comment.
This is a regex, so I think you wanted to leave this unless/until that README gets updated right? (alternatively, you could relax it with something like [^ ]+)
There was a problem hiding this comment.
I opened nodejs/node#39227 to updated the README, but this script isn't used often, so i'm not too worried if it temporarily breaks
There was a problem hiding this comment.
This isn't temporary at all apparently, so change to this file should be reverted so the script works
There was a problem hiding this comment.
Or should we just copy https://github.com/nodejs/release-keys/blob/main/keys.list?
ttshivers
left a comment
ttshivers
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. Hopefully these new key servers will be less flaky too.
|
Created PR on the official-images repo (docker-library/official-images#10480). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
4 participants
SKS servers are no longer working, so switches to alternates