Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit message convention #800

Open
PeterDaveHello opened this issue Jun 27, 2018 · 3 comments
Open

Commit message convention #800

PeterDaveHello opened this issue Jun 27, 2018 · 3 comments

Comments

@PeterDaveHello
Copy link
Member

PeterDaveHello commented Jun 27, 2018

Can we follow https://chris.beams.io/posts/git-commit/ to unify the commit message style?

It'll be good to follow a styling guide, just like coding style.

cc @nodejs/docker

@SimenB
Copy link
Member

SimenB commented Jun 27, 2018

@PeterDaveHello
Copy link
Member Author

Not sure if the angular.js style would be too strict? I prefer try to follow the simple 7 rules, but still open to have a try with angular style if it's voted by more members.

@SimenB
Copy link
Member

SimenB commented Jun 27, 2018

It is more strict and possible to verify on CI (commitlint etc). The more convention based approach in your linked post is harder to enforce. Might not be wanted, though 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@SimenB @PeterDaveHello and others