Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promote: add expected assets for Node.js v23 #3915

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

richardlau
Copy link
Member

Similar to the expected assets for Node.js 22, except 32-bit Windows binaries have been dropped.

Refs: nodejs/node#53184
Refs: nodejs/Release#1034


diff -u ansible/www-standalone/tools/promote/expected_assets/v22.x ansible/www-standalone/tools/promote/expected_assets/v23.x
--- ansible/www-standalone/tools/promote/expected_assets/v22.x  2024-09-13 17:14:34.285963919 +0100
+++ ansible/www-standalone/tools/promote/expected_assets/v23.x  2024-09-20 15:36:23.436432951 +0100
@@ -23,23 +23,15 @@
 node-{VERSION}.tar.xz
 node-{VERSION}-win-x64.7z
 node-{VERSION}-win-x64.zip
-node-{VERSION}-win-x86.7z
-node-{VERSION}-win-x86.zip
 node-{VERSION}-win-arm64.7z
 node-{VERSION}-win-arm64.zip
 node-{VERSION}-x64.msi
-node-{VERSION}-x86.msi
 node-{VERSION}-arm64.msi
 win-x64/
 win-x64/node.exe
 win-x64/node.lib
 win-x64/node_pdb.7z
 win-x64/node_pdb.zip
-win-x86/
-win-x86/node.exe
-win-x86/node.lib
-win-x86/node_pdb.7z
-win-x86/node_pdb.zip
 win-arm64/
 win-arm64/node.exe
 win-arm64/node.lib

Similar to the expected assets for Node.js 22, except 32-bit Windows
binaries have been dropped.
@richardlau richardlau merged commit 0d50809 into nodejs:main Sep 24, 2024
1 check passed
@richardlau richardlau deleted the nodejs23 branch September 24, 2024 16:51
@richardlau
Copy link
Member Author

I've added the new file to the server.

root@infra-digitalocean-ubuntu1604-x64-1:/home/staging/tools/promote/expected_assets# ls -al
total 72
drwxr-xr-x 2 root dist 4096 Sep 24 16:52 .
drwxr-xr-x 3 root dist 4096 Jul 22 12:18 ..
-rw-r--r-- 1 root dist 1052 Apr 14  2020 v10.x
-rw-r--r-- 1 root dist 1051 Oct 17  2019 v11.x
-rw-r--r-- 1 root dist  982 Oct 18  2019 v12.x
-rw-r--r-- 1 root dist  982 Oct 18  2019 v13.x
-rw-r--r-- 1 root dist  918 Apr 14  2020 v14.x
-rw-r--r-- 1 root dist  918 Oct 19  2020 v15.x
-rw-r--r-- 1 root dist  988 Apr 12  2021 v16.x
-rw-r--r-- 1 root dist  988 Oct 16  2021 v17.x
-rw-r--r-- 1 root dist  988 May 31  2022 v18.x
-rw-r--r-- 1 root dist 1164 Apr  3  2023 v19.x
-rw-r--r-- 1 root dist 1164 Apr 12  2023 v20.x
-rw-r--r-- 1 root dist 1164 Oct 16  2023 v21.x
-rw-r--r-- 1 root dist 1164 Apr 15 12:08 v22.x
-rw-r--r-- 1 root dist 1004 Sep 24 16:52 v23.x
-rw-r--r-- 1 root dist 1228 Oct 17  2019 v6.x
-rw-r--r-- 1 root dist 1160 Oct 17  2019 v8.x
root@infra-digitalocean-ubuntu1604-x64-1:/home/staging/tools/promote/expected_assets# diff -u v22.x v23.x
--- v22.x       2024-04-15 12:08:34.685081429 +0000
+++ v23.x       2024-09-24 16:52:13.707060439 +0000
@@ -23,23 +23,15 @@
 node-{VERSION}.tar.xz
 node-{VERSION}-win-x64.7z
 node-{VERSION}-win-x64.zip
-node-{VERSION}-win-x86.7z
-node-{VERSION}-win-x86.zip
 node-{VERSION}-win-arm64.7z
 node-{VERSION}-win-arm64.zip
 node-{VERSION}-x64.msi
-node-{VERSION}-x86.msi
 node-{VERSION}-arm64.msi
 win-x64/
 win-x64/node.exe
 win-x64/node.lib
 win-x64/node_pdb.7z
 win-x64/node_pdb.zip
-win-x86/
-win-x86/node.exe
-win-x86/node.lib
-win-x86/node_pdb.7z
-win-x86/node_pdb.zip
 win-arm64/
 win-arm64/node.exe
 win-arm64/node.lib
root@infra-digitalocean-ubuntu1604-x64-1:/home/staging/tools/promote/expected_assets#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants