Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add manual step for OSX Keychain profile #3569

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Nov 13, 2023

Main Changes

This will be the first step for #3545. This step creates the kaychain profile NODE_RELEASE_PROFILE that later on will be used while notarizing the binaries. Code reference.

This PR change is only for documentation. The updated machines were tested in a separate PR (nodejs/node#50715) in the Node repo while updating the xcrun notarytool submit command in /tools/osx-notarize.sh

The following machines have been updated manually:

  • release-orka-macos11-x64-1
  • release-nearform-macos11.0-arm64-1
  • release-macstadium-macos11.0-arm64-1

Context

@UlisesGascon UlisesGascon changed the title [WIP] docs: add manual step for OSX Keychain profile docs: add manual step for OSX Keychain profile Nov 13, 2023
@UlisesGascon UlisesGascon marked this pull request as ready for review November 13, 2023 17:34
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlisesGascon UlisesGascon merged commit 0734aaa into nodejs:main Nov 19, 2023
1 check passed
@UlisesGascon UlisesGascon deleted the docs/osx-keychain-profile branch November 19, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants