ansible: updates for IBM i by richardlau · Pull Request #3358 · nodejs/build

richardlau · 2023-05-17T21:34:46Z

Update to use current yum repositories for IBM i 7.3.
Install Python 3.9, and use it to install tap2junit.
Do not set group on the .ssh directory on platforms such as IBM i and z/OS where we do not create a group.

Refs: #2937
Refs: https://ibmi-oss-docs.readthedocs.io/en/latest/yum/IBM_REPOS.html

Update to use current yum repositories for IBM i 7.3. Install Python 3.9, and use it to install `tap2junit`. Do not set group on the `.ssh` directory on platforms such as IBM i and z/OS where we do not create a group. Refs: nodejs#2937 Refs: https://ibmi-oss-docs.readthedocs.io/en/latest/yum/IBM_REPOS.html

richardlau · 2023-05-17T21:36:07Z

I've deployed this on the two iinthecloud and the rzkh hosted IBM i machines.

mhdawson

LGTM

richardlau · 2023-05-17T22:52:45Z

Test build has failed: https://ci.nodejs.org/job/node-test-commit-ibmi/1161/nodes=ibmi73-ppc64/console
Looks like it's failed to detect the architecture properly -- probably as a result of now running with Python 3.9.

richardlau · 2023-05-18T12:40:17Z

Test build has failed: https://ci.nodejs.org/job/node-test-commit-ibmi/1161/nodes=ibmi73-ppc64/console Looks like it's failed to detect the architecture properly -- probably as a result of now running with Python 3.9.

Trying nodejs/node#48056 -- looks like some updates were missed from nodejs/node#46739 (presumably because IBM i dynamically link OpenSSL for their rpms).
https://ci.nodejs.org/job/node-test-commit-ibmi/1163/

richardlau · 2023-05-19T15:45:13Z

From nodejs/node#48056 (comment) it sounds like an additional V8 change is needed to allow Node.js to build with Python 3.9 on IBM i. For now I've edited node-test-commit-ibmi to use Python 3.6 (PYTHON=/QOpenSys/pkgs/bin/python3.6) to build Node.js. We need Python 3.9 on the system to run the updated tap2junit.

https://ci.nodejs.org/job/node-test-commit-ibmi/1166/nodes=ibmi73-ppc64/ completed with the three known test failures, so merging.

Update to use current yum repositories for IBM i 7.3. Install Python 3.9, and use it to install `tap2junit`. Do not set group on the `.ssh` directory on platforms such as IBM i and z/OS where we do not create a group. Refs: nodejs#2937 Refs: https://ibmi-oss-docs.readthedocs.io/en/latest/yum/IBM_REPOS.html

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: #48056 Refs: #46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

When built with Python 3.9 on IBM i, `process.platform` will return `os400` instead of `aix`. In preparation for this, make `common.isAIX` only return true for AIX and update the tests to add checks for `common.isIBMi` where they were missing. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Python 3.9 on IBM i returns "os400" for `sys.platform`. PR-URL: nodejs#48056 Refs: nodejs#46739 Refs: nodejs/build#3358 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>