ansible: add ninja-build to x64 V8 builders

[richardlau]

Fixes: #3206

[richardlau]

I've removed this because I'm not sure if we need this set (the other benchmark machine doesn't set this) and the role is currently broken -- it tries to install packages from ansible/roles/benchmarking/vars/main.yml and fails to find

build/ansible/roles/benchmarking/vars/main.yml

Lines 11 to 13 in f45d157

	- python-eventlet
	- python-numpy
	- python-requests

. Presumably these are available package differences after the upgrade to Ubuntu 22.04.

[richardlau]

The rhel8-x64 updates are just-in-case -- when I set up the rhel8-x64 machines I gave them the ability to build V8 as a fallback in case anything happened to the benchmark machines. They're much slower than the benchmark machines (which is why we're not using them in node-test-commit-v8-linux) but they don't suffer from #3050.

[richardlau]

Test CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5295/
And for rhel8-x64: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/195/

[richardlau]

Test CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5295/ And for rhel8-x64: https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/195/

Well the ninja problem is solved -- the build starts and compiles d8 and passes all V8 tests, compiles node successfully and then fails one of the v8-updates tests due to a problem running perf:

19:13:19 + /usr/bin/python3.10 tools/test.py -j 88 -p tap --mode=release --flaky-tests=run v8-updates
19:13:19 TAP version 13
19:13:19 1..2
19:13:20 not ok 1 v8-updates/test-linux-perf
19:13:20   ---
19:13:20   duration_ms: 215.00800
19:13:20   severity: fail
19:13:20   exitcode: 1
19:13:20   stack: |-
19:13:20     /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf.js:89
19:13:20         throw new Error(`Failed to execute 'perf': ${perf.stderr}`);
19:13:20         ^
19:13:20     
19:13:20     Error: Failed to execute 'perf': perf: error while loading shared libraries: libpython2.7.so.1.0: cannot open shared object file: No such file or directory
19:13:20     
19:13:20         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-linux-perf.js:89:11)
19:13:20         at Module._compile (node:internal/modules/cjs/loader:1267:14)
19:13:20         at Module._extensions..js (node:internal/modules/cjs/loader:1321:10)
19:13:20         at Module.load (node:internal/modules/cjs/loader:1125:32)
19:13:20         at Module._load (node:internal/modules/cjs/loader:965:12)
19:13:20         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
19:13:20         at node:internal/main/run_main_module:23:47
19:13:20     
19:13:20     Node.js v20.0.0-pre
19:13:20   ...

[richardlau]

Ah perf is installed via ansible/roles/linux-perf/tasks/main.yml. I'll try removing the built binary and then rerunning the playbook to rebuild it.

[richardlau]

Ah perf is installed via ansible/roles/linux-perf/tasks/main.yml. I'll try removing the built binary and then rerunning the playbook to rebuild it.

Took lots of runs due to #3050, but got a passing V8 CI run on one of the benchmark machines: https://ci.nodejs.org/job/node-test-commit-v8-linux/5305/ 🎉