ansible: add gcc-toolset-10-libatomic-devel on RHEL8#3252
Merged
richardlau merged 1 commit intonodejs:mainfrom Mar 25, 2023
Merged
ansible: add gcc-toolset-10-libatomic-devel on RHEL8#3252richardlau merged 1 commit intonodejs:mainfrom
richardlau merged 1 commit intonodejs:mainfrom
Conversation
V8 CI requires libatomic.
Member
Author
|
I've deployed onto the rhel8-s390x and rhel8-ppc64le machines. Test build has revealed we need a V8 backport for gcc-10 which I'll identify and open after this. 15:39:58 In file included from ../../test/cctest/compiler/test-operator.cc:8:
15:39:58 ../../src/compiler/operator.h: In function ‘void v8::internal::compiler::TestTestOperator1double_Equals()’:
15:39:58 ../../src/compiler/operator.h:185:23: error: array subscript 6 is outside array bounds of ‘v8::internal::compiler::Operator [1]’ [-Werror=array-bounds]
15:39:58 185 | return this->pred_(this->parameter(), that->parameter());
15:39:58 | ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
15:39:58 ../../test/cctest/compiler/test-operator.cc:213:12: note: while referencing ‘op3’
15:39:58 213 | Operator op3(25, NONE, "Weepy", 0, 0, 0, 0, 0, 0);
15:39:58 | ^~~Waiting for the builds currently running on the rhel8-x64 machines to finish before deploying the change there as well (although the V8 CI currently doesn't run on those as the builds take a lot longer than on the benchmark machine (which is currently down)). |
Member
Author
Backport PR: nodejs/node#47236 |
targos
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 CI requires libatomic.
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/5239/nodes=rhel8-s390x,v8test=v8test/console