Visual Studio 2022 support added #3246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Mar 22, 2023
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
Mar 23, 2023
Refs: nodejs#45943 Refs: nodejs#47020 Refs: nodejs/build#3046 Refs: nodejs/build#3246 Refs: nodejs/build#3250 Refs: nodejs/build#3211
PR-URL: nodejs#3246 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Refs: nodejs-private/secrets#252 PR-URL: nodejs#3246 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
StefanStojanovic
force-pushed
the
mefi-vs2022
branch
from
cf5ed4b to
90bb34d
Compare
StefanStojanovic
added a commit
that referenced
this pull request
Mar 27, 2023
PR-URL: #3246 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ulises Gascón <UlisesGascon@users.noreply.github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for installing VS2022 on Windows VMs. It is also a follow on PR for the https://github.com/nodejs-private/secrets/pull/252 updating the inventory file to match changes from secrets.