Skip to content

template: update zlib to 1.2.13 #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

template: update zlib to 1.2.13 #3067

merged 1 commit into from
Nov 7, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Nov 3, 2022

curl -sL https://zlib.net/zlib-1.2.12.tar.gz | tar zxv --strip=1 is 404

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
Copy link
Member

@sxa has pointed me to https://www.zlib.net/fossils/ which appears to have all of the releases -- zlib appear to remove the previous version from https://zlib.net/ when a new one is released. We could point to the tarball from https://www.zlib.net/fossils/ so that the Dockerfile doesn't break from underneath us in the future. (We should still aim to periodically update zlib and the other things in the container, but at our own pace when we are ready to.)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 205235d into nodejs:main Nov 7, 2022
richardlau added a commit to richardlau/build that referenced this pull request Nov 13, 2022
richardlau added a commit that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants