ansible: build gn from source on Linux PPC/s390x #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `build-test-v8` meta-role for installing prerequisites for V8 building/testing. Add roles to build `gn` and `ninja` binaries from source and call those from the `build-test-v8` role for Linux on ppc64/s390x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
build-test-v8meta-role for installing prerequisites for V8building/testing. Add roles to build
gnandninjabinaries fromsource and call those from the
build-test-v8role for Linux onppc64/s390x.
This removes a previously manual step from the Linux PPC/s390x setup (docs also updated).
I've deployed this onto
to update the version of
gn(the version we'd previously manually compiled is now too old, see nodejs/node#38990 (comment)).We're now updated to: