Add M1 macs #2565
Merged
Add M1 macs #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done. |
richardlau
reviewed
Mar 11, 2021
nschonni
reviewed
Mar 11, 2021
richardlau
reviewed
Mar 11, 2021
nschonni
reviewed
Mar 11, 2021
| @@ -87,6 +87,10 @@ needs_monit: [ | |||
| 'debian7', | |||
| ] | |||
|
|
|||
| archtype: { | |||
| macos11.0: 'arm64' | |||
There was a problem hiding this comment.
Is there not going to be any Intel testing on macOS 11?
There was a problem hiding this comment.
Currently no, we dont have the machines for it.
There was a problem hiding this comment.
@AshCripps we probably add a task to add macOS 11 machines for intel, I believe we have enough capacity to do that right?
mhdawson
reviewed
Mar 12, 2021
added 8 commits
March 22, 2021 15:47
Also clean up some out of date machines
AshCripps
force-pushed
the
apple-silicon
branch
from
10b20b3 to
ddb4e27
Compare
richardlau
reviewed
Mar 22, 2021
richardlau
reviewed
Mar 24, 2021
| @@ -8,6 +8,6 @@ | |||
| - name: "ccache : add ccache to the path (macos)" | |||
| when: ccache_mac.rc == 1 | |||
| lineinfile: | |||
| dest: "etc/paths" | |||
| dest: "/etc/paths" | |||
| insertbefore: BOF | |||
| line: "usr/local/opt/ccache/libexec" | |||
There was a problem hiding this comment.
Suggested change
| line: "usr/local/opt/ccache/libexec" | |
| line: "/usr/local/opt/ccache/libexec" |
Sorry, looks like I inadvertently dropped the leading slash in the refactor in https://github.com/nodejs/build/pull/2569/files#diff-01b473334dd8c7ebd76126710bd5ba533d6334a363653425f7d4b27adff36616.
added 2 commits
March 24, 2021 16:04
richardlau
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ansible scripts to support apple silicon and add the three new M1 macs donated to us by macstadium.
@nodejs/build-infra can I get
207.254.38.74added to the release ci firewall and207.254.38.86+207.254.38.89to the test ci firewall please?The commented lines will be readded this branch is quite old so I had some bugs to iron out