Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting Nearform Windows ARM64 machines. #3286

Closed
StefanStojanovic opened this issue Apr 5, 2023 · 11 comments
Closed

Resetting Nearform Windows ARM64 machines. #3286

StefanStojanovic opened this issue Apr 5, 2023 · 11 comments

Comments

@StefanStojanovic
Copy link
Contributor

Currently, 2 Nearform Windows ARM64 machines in CI are not used: test-nearform_arm-win10_vs2019-arm64-1 and test-nearform_arm-win10_vs2019-arm64-2. They were configured manually, so they are not in line with the other machines setup via Ansible scripts. Can we reset them to a clean state, so I can configure them through Ansible and include them in test jobs for Windows on ARM?

cc @jasnell @nodejs/platform-windows-arm

Refs: #2540

@jasnell
Copy link
Member

jasnell commented Apr 5, 2023

I've no access to these machines any longer. @RafaelGSS maybe?

@sxa
Copy link
Member

sxa commented Apr 5, 2023

Just to be clear, is the configuration causing any problems (I know we've been running tests on those from before we had the Azure ones) or is this purely a desire to have them set up "properly" (To be clear, I don't object to this either way - just interested to see if anything is actively broken on them)

Pretty sure I've still got login access but for a reinstall you'd definitely want someone on-site ;-)

@StefanStojanovic
Copy link
Contributor Author

Hi @sxa. Since those machines were set up manually I think their reliability is questionable. As I recall, they were used to test things out in the beginning and a few different approaches were used. I do not remember everything now, but when I started working on them I remember having some issues e.g. VS 2019 and 2022 were both installed, Python was not on the correct version, Jenkins was started via NSSM, etc. While working on those issues, we got Azure VMs so I shifted my focus to them.

My concern is that all those manual changes could have left some leftovers which may affect their behavior. Honestly, I do not know what's the state of those machines now and since the Azure machines we have cover our needs for now, I'm hesitant to try adding Nearform machines for testing. If they were reset and set up cleanly adding them would not be a problem in my opinion.

Btw, I have access to those machines too, but as you said, for reinstalling them I need someone on-site.

@sxa
Copy link
Member

sxa commented Apr 7, 2023

@StefanStojanovic Yep totally agree with all of that :-) And yes when the Linaro team started actively working on this we were using those machines to see what could make things work via standalone Win/Arm64 jobs before integrating into the main pipelines so they're no longer as clean from the perspective of the playbooks as they would otherwise be.

I'm hesitant to try adding Nearform machines for testing.

Have they been actively excluded? I assumed they were still being used in the jobs even though this cleanup hasn't been done.

@StefanStojanovic
Copy link
Contributor Author

Have they been actively excluded? I assumed they were still being used in the jobs even though this cleanup hasn't been done.

Since Azure ARM64 machines are Windows 11, their labels start with win11-.... On the other hand, Nearform machines were created as Windows 10 (although they were upgraded to Windows 11 at some point), so their labels start with win10-.... We've configured test jobs to use only Azure machines.

@sxa
Copy link
Member

sxa commented Apr 7, 2023

Gotcha - we had it running on the node-test-commit-... jobs on the NearForm machines with the win10 labels but I see that's been changed now.

@RafaelGSS
Copy link
Member

cc @efrisby

@StefanStojanovic
Copy link
Contributor Author

@efrisby, do you have access to those machines? If you're able to reset them, reboot them if/when required, and configure RDP, I could do the rest to get them ready for the CI. It would be good for the RDP and machines to be set up the same as they are now (username, password, ports, etc.), but that's not mandatory.

Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Feb 23, 2024
@sxa
Copy link
Member

sxa commented Feb 27, 2024

I'm going to ping this issue to keep it alive pending the nearform machine migration, however it seems likely that they will be deommissioned as per #3615 (comment)

@github-actions github-actions bot removed the stale label Feb 28, 2024
@StefanStojanovic
Copy link
Contributor Author

Closing this, since the Nearform machines are removed from the CI and the build repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants