Install Python 3 everywhere in CI

[targos]

This is a requirement for nodejs/node#36691
There are a lot of hosts that only have Python 2 installed.

For example, in ci-release, only the Windows builds work if we remove Python 2 support: https://ci-release.nodejs.org/job/iojs+release/6555/

[cclauss]

I do not have access rights for the link above... How many hosts are we talking about that only have legacy Python?

[AshCripps]

It is a fair few of the host - interestingly the mac builds failed in that release build and they most certainty do have python3 installed.

[cclauss]

Python 2 died over a year ago (not even security updates) so it is a security exposure to keep those hosts online.

Can you please paste some details on how Py3 on macOS is failing?

[targos]

15:41:54 PRODUCTSIGN_CERT=Developer ID Installer: Node.js Foundation
15:41:54 CODESIGN_CERT=Developer ID Application: Node.js Foundation
15:41:54 NOTARIZATION_ID=build@iojs.org
15:41:54 PACKAGEMAKER=~/PackageMaker.app/Contents/MacOS/PackageMaker
15:41:54 
15:41:54 [EnvInject] - Variables injected successfully.
15:41:54 [ws] $ /bin/bash -ex /var/folders/zq/929cmt8n33j9_8x7b06pbzqh0000gp/T/jenkins490912561010356266.sh
15:41:54 + RELEASE_URLBASE=https://nodejs.org/download/test/
15:41:54 + '[' Xtest == Xtest ']'
15:41:54 + disttype=custom
15:41:54 + CUSTOMTAG=test20201230f8775b51b5
15:41:54 + RELEASE_URLBASE=https://nodejs.org/download/test/
15:41:54 + CONFIG_FLAGS='--download-path=/Users/iojs/node-icu/ --verbose'
15:41:54 + '[' -z x ']'
15:41:54 + mkdir -p /Users/iojs/node-icu/
15:41:54 + make -j 2 pkg-upload DESTCPU=x64 ARCH=x64 DISTTYPE=custom DATESTRING=20201230 COMMIT=f8775b51b5 CUSTOMTAG=test20201230f8775b51b5 RELEASE_URLBASE=https://nodejs.org/download/test/ 'CONFIG_FLAGS=--download-path=/Users/iojs/node-icu/ --verbose'
15:41:59 rm -f -r out/macos
15:41:59 mkdir -p out/macos/installer/productbuild
15:41:59 cat tools/macos-installer/productbuild/distribution.xml.tmpl  \
15:41:59 		| sed -E "s/\\{nodeversion\\}/v16.0.0-test20201230f8775b51b5/g" \
15:41:59 		| sed -E "s/\\{npmversion\\}/v7.3.0/g" \
15:41:59 	>out/macos/installer/productbuild/distribution.xml ; \
15:41:59 
15:41:59 Found localization directory tools/macos-installer/productbuild/Resources/en.lproj/
15:41:59 python ./configure \
15:41:59 		--dest-cpu=x64 \
15:41:59 		--tag=test20201230f8775b51b5 \
15:41:59 		--release-urlbase=https://nodejs.org/download/test/ \
15:41:59 		--download-path=/Users/iojs/node-icu/ --verbose --download=all --with-intl=full-icu
15:41:59 Please use python3.9 or python3.8 or python3.7 or python3.6.
15:41:59 	/usr/local/bin/python3.7 ./configure
15:41:59 Node.js configure: Found Python 2.7.16...
15:41:59 make: *** [node-v16.0.0-test20201230f8775b51b5.pkg] Error 1
15:41:59 Build step 'Conditional steps (multiple)' marked build as failure
15:42:00 Archiving artifacts
15:42:00 Sending e-mails to: michael_dawson@ca.ibm.com
15:42:01 Notifying upstream projects of job completion
15:42:01 Finished: FAILURE

[AshCripps]

Ah so thats because we call python configure and system python on mac for some reason is still 2.7.16

[cclauss]

Yes. I think we just need to sync up to nodejs/node#35983

[targos]

Yes. I think we just need to sync up to nodejs/node#35983

I think we have that commit. Your branch is synced up to Dec 29.

[AshCripps]

I think the issue is the way the job is setup by directly calling python ./configure. example on my laptop

ash:node/ (master) $ ./configure                                                                                                            [16:53:59]
Node.js configure: Found Python 3.9.1...
...
INFO: configure completed successfully
ash:node/ (master) $ python ./configure                                                                                                     [16:54:15]
Node.js configure: Found Python 2.7.16...
...
INFO: configure completed successfully
ash:node/ (master) $

putting python infront causes it to find python2 not 3

[aduh95]

The Makefile is using $(PYTHON) from the environment. I guess a fix would be to specify the full path of python3 in the environment variable.

[richardlau]

Building up the current state on our CI hosts:
ppc hosts: ansible --list-hosts "*ppc*"
s390 hosts: ansible --list-hosts "*s390*"
smartos hosts: ansible --list-hosts "*smartos*"
freebsd hosts: ansible --list-hosts "*freebsd*"

host	python --version	python3 --version	notes	action
release-ibm-aix71-ppc64_be-2	2.7.18	-		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
release-iinthecloud-ibmi72-ppc64_be-1			unreachable
release-osuosl-aix72-ppc64_be-1	2.7.18	3.6.12		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
release-osuosl-centos7-ppc64_le-1	2.7.5	3.6.8
test-ibm-aix71-ppc64_be-3	2.7.18	-		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
test-ibm-aix71-ppc64_be-4	2.7.18	-		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
test-iinthecloud-ibmi72-ppc64_be-1	3.6.10	3.6.10		Python 3.6.12 installed in /QOpenSys/pkgs/bin/python and /QOpenSys/pkgs/bin/python3 #2567
test-iinthecloud-ibmi72-ppc64_be-2	2.7.18	-		Python 3.6.12 installed in /QOpenSys/pkgs/bin/python and /QOpenSys/pkgs/bin/python3 #2567
test-osuosl-aix72-ppc64_be-2	2.7.18	3.6.12		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
test-osuosl-aix72-ppc64_be-3	2.7.18	3.6.12		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
test-osuosl-aix72-ppc64_be-4	2.7.18	3.6.12		Python 3.7.9 installed in /opt/freeware/bin/python3 #2564
test-osuosl-centos7-ppc64_le-1	2.7.5	3.6.8
test-osuosl-centos7-ppc64_le-2	2.7.5	3.6.8
release-ibm-rhel7-s390x-1	2.7.5	-		Python 3.6.8 installed in /usr/bin/python3 #2571
release-marist-zos24-s390x-1	2.7.13	-	Not building Node.js yet. libuv builds do not use Python.
test-ibm-rhel7-s390x-1	2.7.5	-		Python 3.6.8 installed in /usr/bin/python3 #2571
test-ibm-rhel7-s390x-2	2.7.5	-		Python 3.6.8 installed in /usr/bin/python3 #2571
test-ibm-rhel7-s390x-3	2.7.5	-		Python 3.6.8 installed in /usr/bin/python3 #2571
test-ibm-rhel7-s390x-4	2.7.5	-		Python 3.6.8 installed in /usr/bin/python3 #2571
test-marist-zos24-s390x-1	2.7.13	-	Not building Node.js yet. libuv builds do not use Python.
test-marist-zos24-s390x-2	2.7.13	-	Not building Node.js yet. libuv builds do not use Python.
infra-joyent-smartos15-x64-1	2.7.11	-	Infra machine -- we do not build on this
release-joyent-smartos17-x64-2	2.7.14	-		Python 3.6.4 installed in /opt/local/bin/python3 #2575
release-joyent-smartos18-x64-2	2.7.15	-		Python 3.7.1 installed in /opt/local/bin/python3 #2575
test-joyent-smartos17-x64-3	2.7.14	-		Python 3.6.4 installed in /opt/local/bin/python3 #2575
test-joyent-smartos17-x64-4	2.7.14	-		Python 3.6.4 installed in /opt/local/bin/python3 #2575
test-joyent-smartos18-x64-3	2.7.15	-		Python 3.7.1 installed in /opt/local/bin/python3 #2575
test-joyent-smartos18-x64-4	2.7.15	-		Python 3.7.1 installed in /opt/local/bin/python3 #2575
test-digitalocean-freebsd11-x64-1	3.7.10	3.7.10	Python 2.7.18 in /usr/local/bin/python2
test-digitalocean-freebsd11-x64-2	3.7.10	3.7.10	Python 2.7.18 in /usr/local/bin/python2
release-packetnet-centos7-arm64-1	2.7.5	-		Python 3.6.8 installed under /usr/bin/python3 #2585
test-packetnet-centos7-arm64-1	2.7.5	-		Python 3.6.8 installed under /usr/bin/python3 #2585
test-packetnet-centos7-arm64-2	2.7.5	-		Python 3.6.8 installed under /usr/bin/python3 #2585
test-packetnet-ubuntu1604-arm64-1	2.7.12	3.5.2	not used for Node.js 14+
test-packetnet-ubuntu1604-arm64-2	2.7.12	3.5.2	not used for Node.js 14+
release-digitalocean-centos7-x64-1	2.7.5	-	ansible errors	Python 3.6.8 installed under /usr/bin/python3
test-rackspace-centos7-x64-1	2.7.5	-	ansible errors	Python 3.6.8 installed under /usr/bin/python3
test-softlayer-centos7-x64-1	2.7.5	-	ansible errors	Python 3.6.8 installed under /usr/bin/python3

Others:

container	python --version	python3 --version	notes	action
alpine 3.11	2.7.18	-	Dockerfile	Python 3.8.2 installed under /usr/bin/python3 #2589
alpine 3.12	3.8.3	3.8.3	Dockerfile - not used to build Node.js 10 and 12 (no Python 2)