Test Coverage?

[DavidTPate]

Hey there!

I'm looking for some ways to get involved, and it looks like there is code coverage on the roadmap but as best as I can tell there isn't any progress with it. It seems to me that the build WG is the place where such progress would be made, so I wanted to check here and see if you guys knew of anything in progress or if there had been anything more about it published out there.

I took a look through TSC notes and your meeting notes here but wasn't able to find anything particularly related to code coverage.

[jbergstroem]

Hey! What are your thoughts on the matter? Outlining how your solution would look could be a great way to get involved.

[mhdawson]

I'm not aware of any work on that front but do think its important/interesting. As jbergstroem mentions a good first step would be to document what you think the next steps would be.

[DavidTPate]

Cool, I'll do some additional digging into the testing pipeline that's running right now. IIRC it uses Python to orchestrate everything, so that's likely where instrumentation would be added. It seems like it will take 2 different solutions to determine the coverage of the Javascript & C++ code.

[rvagg]

@chrisdickinson began some work on code coverage, perhaps we can pester him for his code.

[balupton]

I'm also wondering about this. Would be very insightful to know how much of node.js is actually tested. Including the deps.

Has there been a reason this has not been tackled yet? From my understanding, test coverage is an indicator of stability and quality, perhaps my understanding is wrong, or there has just been more important factors for Node.js world.

[evanlucas]

Last I checked, the js was ~72% covered. It was a nightmare to setup, but I'll see if I can do it again

[jbergstroem]

@balupton the reason it hasn't been tackled is because no one has stepped up and written any code. Feel free to chip in if you have the time!

[evanlucas]

Woah I was way off. More like 85% https://nodejs-coverage-sduffwsopa.now.sh/

That's really old though. I'll try and post the changes I had to make tomorrow.

[rvagg]

This might be a good thread to move over to https://github.com/nodejs/testing, it may even be something already on the radar for them, also the Testing Working Group is a great place to get involved and contributing some coverage tooling would be an excellent start.

[santigimeno]

This might be a good thread to move over to https://github.com/nodejs/testing, it may even be something already on the radar for them

Yes, it was something we had on the radar, but no work has been done yet.

Testing Working Group is a great place to get involved and contributing some coverage tooling would be an excellent start.

Yes, it would be great having more people involved! :D

[evanlucas]

For anyone interested, evanlucas/node@1445e3d is what I used to generate that. You'll also have to install istanbul. https://nodejs-coverage-kvhhcskvtz.now.sh/ is the results for current master branch.

EDIT: It is really ugly by the way.

[santigimeno]

This is great. Thank you!

[mhdawson]

Coverage work progressed in an issue over in the testing WG: nodejs/testing#36. Closing this issue. Please re-open if you disagree.