Run benchmark test suite nightly

[Trott]

Similar to the way we run internet nightly or maybe made part of node-daily-master, the benchmark tests need to be incorporated into a once-a-day run somehow. They've been moved out of the main test suite.

Refs: nodejs/node#24265

[refack]

Done.
https://ci.nodejs.org/job/node-test-commit-custom-suites/753/

[refack]

There is an issue with the napi benchmark, since the current job doesn't trigger it's build.

[Trott]

There is an issue with the napi benchmark, since the current job doesn't trigger it's build.

Oh, because it doesn't run make test-benchmark, it just directly calls the benchmark tests with tools/test.py. Hmmm.... any recommendations for how to fix?

[refack]

either restore https://github.com/nodejs/node/pull/24265/files#diff-b67911656ef5d18c4ae36cb6741b7965L458
or put an if (benchmark in CI_JS_SUITES) (pseudocode) around it

[refack]

or put a guard in benchmark/napi/function_args/index.js that urges you to run make bench-addons-build

[joyeecheung]

or put a guard in benchmark/napi/function_args/index.js that urges you to run make bench-addons-build

@refack I think I've attempted to do that a while back but I couldn't make child_process play along with node-gyp arguments..(but limited that to make may work?)

[Trott]

I like restoring the one line in https://github.com/nodejs/node/pull/24265/files#diff-b67911656ef5d18c4ae36cb6741b7965L458. While it compiles a file unnecessarily in most cases, it's quick.

[joyeecheung]

Ah, I think I've managed to get it to work in JS this time around..(don't really know why I didn't, maybe I was too sleep-deprived) (considering there is tools/build-addons.js there is no reason it doesn't work I guess)

[Trott]

Ah, I think I've managed to get it to work in JS this time around..(don't really know why I didn't, maybe I was too sleep-deprived) (considering there is tools/build-addons.js there is no reason it doesn't work I guess)

Oh, I just opened nodejs/node#24307. Feel free to close it if you have a better solution!