Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore label filtering #50

Merged
merged 1 commit into from
May 5, 2022
Merged

restore label filtering #50

merged 1 commit into from
May 5, 2022

Conversation

bengl
Copy link
Member

@bengl bengl commented Apr 13, 2022 •
edited
Loading

As far as I can tell, this fixes #45.

This depends on nodejs/changelog-maker#127

The labels get cached, so it's fine that we call it once here and again inside processCommits.

@bengl bengl mentioned this pull request Apr 13, 2022
Merged
@bengl
Copy link
Member Author

bengl commented Apr 14, 2022

Note: If attempting to test this locally and the changelog-maker PR hasn't landed and been released yet, you'll have to apply the change from that PR manually, i.e. adding the missing export in node_modules/changelog-maker/package.json.

@richardlau richardlau mentioned this pull request Apr 14, 2022
Closed
richardlau
richardlau approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think the flow would be to get nodejs/changelog-maker#127 merged, release a new version of changelog-maker and then add a version bump for changelog-maker to the dependencies for branch-diff in this PR.

@bengl
Copy link
Member Author

bengl commented May 5, 2022

@richardlau the changelog-maker PR is now merged and released, so I've bumped that in package.json here. (And added the conventional-commit prefix for semantic-release purposes.)

@bengl bengl merged commit 660a71f into nodejs:main May 5, 2022
github-actions bot pushed a commit that referenced this pull request May 5, 2022
@semantic-release-bot
chore(release): 2.0.4 [skip ci]
56112ea 
### [2.0.4](v2.0.3...v2.0.4) (2022-05-05)

### Bug Fixes

* restore label filtering ([#50](#50)) ([660a71f](660a71f))

### Trivial Changes

* **no-release:** bump standard from 16.0.4 to 17.0.0 ([#52](#52)) ([a87c38f](a87c38f))
@github-actions
Copy link

github-actions bot commented May 5, 2022

🎉 This PR is included in version 2.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@rvagg rvagg rvagg approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not excluding labels with branch-diff v2.0.0
4 participants
@bengl @rvagg @richardlau @BethGriggs