-
Notifications
You must be signed in to change notification settings - Fork 144
Reword Collaborator as Member #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
legendecas
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
legendecas:role-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
approved these changes
May 30, 2025
richardlau
reviewed
May 30, 2025
richardlau
approved these changes
Jun 2, 2025
RafaelGSS
approved these changes
Jun 2, 2025
marco-ippolito
approved these changes
Jun 2, 2025
JohnTitor
approved these changes
Jun 2, 2025
bjohansebas
approved these changes
Jun 2, 2025
avivkeller
reviewed
Jun 2, 2025
@@ -66,8 +66,8 @@ accomplished in one of four ways: | |||
* Via a new Post in the same thread as the Post being requested for Moderation, | |||
* Via a new Post in the private nodejs/moderation repository. | |||
|
|||
Note that Collaborators may Moderate non-Collaborator Posts at any time without | |||
submitting an initial request (see: [Non-Collaborator Posts][]). | |||
Note that Members with triage permissions may Moderate non-Members Posts at any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Note that Members with triage permissions may Moderate non-Members Posts at any | |
Note that Members may Moderate non-Members Posts at any |
We specify that "Member" refers to a member with Triage permissions, so saying it again isn't needed.
avivkeller
reviewed
Jun 2, 2025
* A non-Collaborator posts a comment that indicates that they are a bot. | ||
* A collaborator sees the post and hides it. | ||
* A non-Member posts a comment that indicates that they are a bot. | ||
* A member sees the post and hides it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* A member sees the post and hides it. | |
* A Member sees the post and hides it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the moderation policy, the term "Collaborator" actually refers to any individual with configured triage role or higher in any Node.js GitHub organization repository, but not the well-known term in Node.js that refers to who has write access to a certain repo like https://github.com/nodejs/node.
This updates the Moderation-Policy.md to disambiguate the term from the "Collaborator" that's commonly used in the context of Node.js org.
/cc @nodejs/moderation @nodejs/tsc