Fix undefined snprintf use for older compiler (#178)

jasongin · web-flow · commit fb18a185e624 · 2017-03-21T16:44:42.000-07:00
The snprintf API is not available with older versions of MSVC. Found by a CI run.
diff --git a/test/addons-napi/test_buffer/test_buffer.cc b/test/addons-napi/test_buffer/test_buffer.cc
@@ -44,7 +44,7 @@ void newBuffer(napi_env env, napi_callback_info info) {
                 reinterpret_cast<void**>(&theCopy),
                 &theBuffer));
   JS_ASSERT(env, theCopy, "Failed to copy static text for newBuffer");
-  snprintf(theCopy, kBufferSize, "%s", theText);
+  memcpy(theCopy, theText, kBufferSize);
   NAPI_CALL(env, napi_set_return_value(env, info, theBuffer));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ void newBuffer(napi_env env, napi_callback_info info) {`
`44`	`44`	`reinterpret_cast<void**>(&theCopy),`
`45`	`45`	`&theBuffer));`
`46`	`46`	`JS_ASSERT(env, theCopy, "Failed to copy static text for newBuffer");`
`47`		`- snprintf(theCopy, kBufferSize, "%s", theText);`
	`47`	`+ memcpy(theCopy, theText, kBufferSize);`
`48`	`48`	`NAPI_CALL(env, napi_set_return_value(env, info, theBuffer));`
`49`	`49`	`}`
`50`	`50`