-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override objection in - display Node.js version at the end of stacktraces [#38332](https://github.com/nodejs/node/pull/38332) #1078
Comments
+1 from me. |
I'll abstain. (I'm +0.5 on the change. I will leave the decision to people who have engaged in the issue and/or thought more about this than I have and/or have more fully-formed and strongly-held views.) |
+1 |
2 similar comments
+1 |
+1 |
abstain, not familiar enough with discussion |
+1 |
1 similar comment
+1 |
FWIW, the Collaborator Guide allows the objection to be dismissed without a need for a TSC override when the objector is not responsive: https://github.com/nodejs/node/blob/0d88c141cbebc3efc5e57db8ef0bf6550cfb62b6/doc/guides/collaborator-guide.md#L159-L161 That being said, I'm +1 on a override. |
I thought the same thing, but then looked at the issue, and I think it's not clear cut. They responded to some questions. There's only one comment that they've been mentioned in since their last comment, and it ends with "Is there something that would be critical in case we'd add this? Elaborating your -1 further would be great!" That's inviting a response, but doesn't seem to be really requiring one. I think it's best to formally vote because that conversation has likely run its four-month course. |
Keeping tally. Feel free to edit this to update it.
Total TSC member count: 22 Vote has passed. |
Yes |
@nodejs/tsc we need 1 more yes or 4 more abstentions. If we can close on this I'll propose we cancel the in person meeting for this week. |
Small correction: It needs 2 more yes votes (or 4 abstentions, or 10 no votes). (If two more people abstain, then it needs only 1 vote or 9 no votes.) |
I'll abstain. |
+1 to override but will leave some comments on the PR. |
Yes (and should it cause a widespread regression we can always turn if off by default) |
+1 to override with @joyeecheung consideration. |
I'll abstain. |
1 similar comment
I'll abstain. |
As per the update in #1078 (comment), the vote has now passed. |
We discussed in the TSC meeting this week that:
@nodejs/tsc please comment in this issue if you have any objections or +1 to indicate you are in agreement to override. If we have sufficient +1s by the next TSC meeting and no objections we'll move forward with the override.
The text was updated successfully, but these errors were encountered: