Skip to content

Commit

Permalink
Move TSC meeting minutes into nodejs/tsc repo (#164)
Browse files Browse the repository at this point in the history
  • Loading branch information
jasnell committed Nov 18, 2016
1 parent db6089c commit ddd72be
Show file tree
Hide file tree
Showing 38 changed files with 4,946 additions and 0 deletions.
143 changes: 143 additions & 0 deletions meetings/2015-05-27.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,143 @@
# Node Foundation TSC Meeting 2015-05-27

## Links

* **Audio Recording**: https://soundcloud.com/node-foundation/tsc-meeting-2015-05-27
* **Public YouTube feed**: http://www.youtube.com/watch?v=0DPfLxulsbQ
* **GitHub Issue**: https://github.com/nodejs/node-convergence-archive/issues/41
* **Original Minutes Google Doc**: https://docs.google.com/document/d/1-KlxiQGMsJFNJu3meok9e9XFsM39k_PMnQmY_9d_cy0

## Agenda

Extracted from **tsc-agenda** labelled issues and pull requests prior to meeting.

### nodejs/node-convergence-archive

* \[Converge\] timers: Avoid linear scan in `_unrefActive`. [#23](https://github.com/nodejs/node-convergence-archive/issues/23)
* \[Converge\] child_process argument type checking [#22](https://github.com/nodejs/node-convergence-archive/issues/22)
* \[Converge\] SSLv2/3 disable/enable related commits [#20](https://github.com/nodejs/node-convergence-archive/issues/20)
* doc: Add new working groups [#15](https://github.com/nodejs/node-convergence-archive/pull/15)

### nodejs/io.js

* Buffer implemented using Uint8Array [#1810](https://github.com/nodejs/io.js/issues/1810)
* \[Discussion\] FFI - Giving Buffer more low-level C functionality [#1750](https://github.com/nodejs/io.js/pull/1750)
* Chrome 43 released; time for V8 4.3! [#1735](https://github.com/nodejs/io.js/issues/1735)
* Deprecation Policy [#1704](https://github.com/nodejs/io.js/issues/1704)
* TSC needs to elect a board representative. [#1697](https://github.com/nodejs/io.js/issues/1697)
* V8 4.4 to remove indexed properties via external data [#1451](https://github.com/nodejs/io.js/issues/1451)

### joyent/node

## Present

* Alexis Campailla (TSC)
* Ben Noordhuis (TSC)
* Bert Belder (TSC)
* Brian White
* Chris Dickinson (TSC)
* Colin Ihrig (TSC)
* James M Snell (TSC)
* Jeremiah Senkpiel (TSC)
* Mikeal Rogers
* Michael Dawson (TSC)
* Mike Dolan (TSC)
* Rod Vagg (TSC)
* Shigeki Ohtsu
* Trevor Norris (TSC)

## Quick stand-up

* Rod: Working on combining the build, 3.0
* James: Working on repo convergence, triaging joyent/node issues, LTS policy drafting
* Shigeki: Investigating a slow tls test and SSL mitigations for a log jam attack.
* Jeremiah: Lots of little things
* Colin: Libuv work for os.homedir()
* Chris: Removing sys, checking breakage; fixing bug I introduced in persistent history
* Bert: Looking at issues
* Alexis: Working on combining the build, fixing windows issues
* Trevor: Working on the new Buffer impl using Uint8Array
* Michael: Traging joyent/node, spun up the benchmarking WG, looking into adding powerpc build machines
* Brian: Almost done the pure JS dns resolver, all tests are passing
* Ben:
- Make require faster
- Date.now() perf improvements

## Review of last meeting

* _Skipping_

## Minutes

### \[Converge\] timers: Avoid linear scan in `_unrefActive`. [#23](https://github.com/nodejs/node-convergence-archive/issues/23)

* James: conflicting approaches in both repos
* Ben: both are terrible under different workloads - do away with the code and start again
* Jeremiah: might have a go at it, working off an existing heap impl by Ben (ACTION)
* Bert: some problems with http - discussion happened about the implementation
* Chris: would be good to have Julien’s input since he was active on the joyent/node impl

### \[Converge\] child_process argument type checking [#22](https://github.com/nodejs/node-convergence-archive/issues/22)

* James: arg checking merged in 0.10 after the fork
* Discussion about why this wasn’t merged to io.js
* Defer back to GitHub discussion after no reason for not merging could be found on the call

### \[Converge\] SSLv2/3 disable/enable related commits [#20](https://github.com/nodejs/node-convergence-archive/issues/20)

* James: SSLv2/3 removed in io.js, merging these commits would involve reverting
* Jeremiah proposed 0.12 being the LTS for SSLv2/3 support
* Rod: are we happy killing this off?
* Michael: we don’t know how extensively it’s being used?
* James: pending research into that question we’ll leave this alone, come back if there’s a compelling reason to revert

### doc: Add new working groups [#15](https://github.com/nodejs/node-convergence-archive/pull/15)

* Michael: Benchmarking and Post Mortem Debugging working groups are ready and have started, i18n group needs a bit more work to get off the ground
* Group didn’t see any reason not to go forward with these groups, they have repos and can be in an “incubating” state for now


### Buffer implemented using Uint8Array [#1810](https://github.com/nodejs/io.js/issues/1810)

* Trevor: Buffer using Uint8Array is now working, all applicable tests pass, currently behind a flag:
* Trevor Questions:
- Are we going with v8 4.3 or 4.4?
- If we go v8 4.3, do we want to release behind a flag?
- we still want an upper kMaxlength Buffer size limit?
* Ben: Buffer size limit should be safe to remove
* Rod: 4.3 and 4.4 both contain major breakage for native addons
* Discussed if we would like to delay 3.0 until v8 4.4
* Rod: no appetite here for delaying a 3.0 with 4.3, take discussion on that back to GitHub
* Ben: suggested we release new Buffer impl with a flag to revert to old impl, Jeremiah seconded
* Discussed how hard it would be to land and review
* Fedor: how does it work with 32bit numbers?
* Trevor: It acts the same as before

### \[Discussion\] FFI - Giving Buffer more low-level C functionality [#1750](https://github.com/nodejs/io.js/pull/1750)

* Trevor: concerns about being able to write to buffers and execute arbitrary code
* Rod: concerned about changing the nature of what Node _is_ and the safety it exposes
* Ben suggested that we move this new work to an ffi module rather than hanging it off Buffer
- Group agreed to take this suggestion back to the issue for discussion

### Chrome 43 released; time for V8 4.3! [#1735](https://github.com/nodejs/io.js/issues/1735)

* Concerns about deps forcing semver-major, the C++ API changes are big enough to warrant this though

### Deprecation Policy [#1704](https://github.com/nodejs/io.js/issues/1704)

* Discussion dividing into two camps - conservative camp and those who want to test the size of the impact on the ecosystem
* Suggestion (Michael?) that we use LTS releases to determine when things get properly removed
* Discussed why we want a deprecation policy

### TSC needs to elect a board representative. [#1697](https://github.com/nodejs/io.js/issues/1697)

* Deferred till next meeting - need to nominate and vote someone in to this role and should discuss how we want to structure the role in terms of rotation

### V8 4.4 to remove indexed properties via external data [#1451](https://github.com/nodejs/io.js/issues/1451)

* Nothing to discuss, rolled up in to Buffer discussion earlier

## Next meeting

* June 3rd, 8PM UTC
166 changes: 166 additions & 0 deletions meetings/2015-06-03.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,166 @@
# Node.js Foundation TSC Meeting 2015-06-03

## Links

* **Audio Recording**: https://soundcloud.com/node-foundation/tsc-meeting-2015-06-03
* **GitHub Issue**: https://github.com/nodejs/node-convergence-archive/issues/47
* **Original Minutes Google Doc**: https://docs.google.com/document/d/1sTD0uryasBR15UBzEbJj3oHYtnuN9ZIqVxA2A_-N56E

## Agenda

Extracted from **tsc-agenda** labelled issues and pull requests prior to meeting.

### nodejs/io.js

* Add working group state per Project Lifecycle. [#1880](https://github.com/nodejs/io.js/pull/1880)
* Proposal: Split TSC agenda in to two meetings [#1879](https://github.com/nodejs/io.js/issues/1879)
* Chrome 43 released; time for V8 4.3! [#1735](https://github.com/nodejs/io.js/issues/1735)
* TSC needs to elect a board representative. [#1697](https://github.com/nodejs/io.js/issues/1697)
* Expose `deepEqual` and `deepStrictEqual` in `util`. #1172 [#1177](https://github.com/nodejs/io.js/pull/1177)

## Present

* Rod Vagg (TSC)
* Mikeal Rogers
* Shigeki Ohtsu (TSC)
* Chris Dickinson (TSC)
* Colin Ihrig (TSC)
* Julien Gilli (TSC)
* James Snell (TSC)
* Michael Dawson (TSC)
* Bert Belder (TSC)
* Fedor Indutny (TSC)
* Jeremiah Senkpiel (TSC)
* Domenic Denicola
* Alexis Campailla (TSC)
* Ben Noordhuis (TSC)

## Quick stand-up

* Rod: working on the build, looking into npm smoke-testing
* Mikeal: getting foundation legalities and officialities in order
* Shigeki: working on security issues, reviewing root cert update
* Chris: working on getting npm static analysis working [estoc](https://github.com/chrisdickinson/estoc)
* Colin: reviewing prs and issues, doing some libuv work (uv_os_homedir, which landed in libuv 1.6.0)
* Julien: vacation, nodejs.org downtime postmortem
* James: working on convergence, triaging joyent/node issues
* Michael: triaging some joyent/node issues, working on powerpc build and npm testing
* Bert: not much, looked at some issues, discussing with Saul if libuv should move into the Node Foundation
* Fedor: reviewed some pull requests and issues, working on some openssl mode
* Jeremiah: issues, convergence, `_unrefActive` timers work, looking at improving Ben’s binary heap implementation
* Domenic: vm fixes in v8 integrating patches
* Alexis: patch for timers firing early, CI convergence work - jenkins hackery
* Ben: reviewing pull requests, making libuv threadpool more scalable
* Brian: JS dns resolver
* Trevor: merged UInt8Array Buffer changes into the next branch, additional ArrayBuffer-related changes and fiddling

## Review of last meeting

### nodejs/node

* \[Converge\] timers: Avoid linear scan in `_unrefActive`. [#23](https://github.com/nodejs/node/issues/23)
* \[Converge\] child_process argument type checking [#22](https://github.com/nodejs/node/issues/22)
* \[Converge\] SSLv2/3 disable/enable related commits [#20](https://github.com/nodejs/node/issues/20)
* doc: Add new working groups [#15](https://github.com/nodejs/node/pull/15)

### nodejs/io.js

* Buffer implemented using Uint8Array [#1810](https://github.com/nodejs/io.js/issues/1810)
* \[Discussion\] FFI - Giving Buffer more low-level C functionality [#1750](https://github.com/nodejs/io.js/pull/1750)
* Chrome 43 released; time for V8 4.3! [#1735](https://github.com/nodejs/io.js/issues/1735)
* Deprecation Policy [#1704](https://github.com/nodejs/io.js/issues/1704)
* TSC needs to elect a board representative. [#1697](https://github.com/nodejs/io.js/issues/1697)
* V8 4.4 to remove indexed properties via external data [#1451](https://github.com/nodejs/io.js/issues/1451)

## Minutes

### Add working group state per Project Lifecycle. [#1880](https://github.com/nodejs/io.js/pull/1880)

* Mikeal: making working groups as “core” means they get to elect a TSC seat.
* Brief discussion about what WG’s should be considered “core” and get a TSC seat.
* Deferred to GitHub.

### Chrome 43 released; time for V8 4.3! [#1735](https://github.com/nodejs/io.js/issues/1735)

Domenic: things are ready to go. There’s some concern about double-breakage in 4.3 and 4.4.

Jeremiah: what about the maybe changes?

Domenic: the non-Maybe versions are still there, and haven’t been removed yet, either in 4.3 or 4.4 or even 4.5 (which isn’t finalized yet though).

Rod: blocker is whether the double-breakage is real, if not then we should move forward.

Domenic: there’s also the issue of some people in the thread advocating blocking a release on readying the ecosystem.

Rod: we shouldn’t be following the ecosystem and waiting for them to catch up before we release.

Mikeal: it’s more a matter of how we approach these things.

Michael: LTS should help this?

Mikeal: the problem is about major releases and the messaging - currently when people download them lots of stuff is broken.

Domenic called for a vote on a 3.0 release _assuming there is no double-breakage_.

Rod: I need to get the fix for node-gyp in place. Also we should see if we can get nvm to allow testing nightlies so that people can test them more easily (including on Travis).

Jeremiah: when I last talked to Jordan (@ljharb) he wanted to make sure that the mechanism we used for nightlies would also be the mechanism used in the converged project.

Mikeal: well that’s definitely true. So we should be good.

Trevor: do we have a way of measuring uptake?

Domenic/Rod: npm traffic is probably the best metric.

Rod calls for a vote.

Domenic: can we clarify whether we allow minor, covered-by-nan breakages between 4.3/3.0.0 and 4.4/4.0.0, or do we require no breakages at all?

Mikeal: is nan released?

Jeremiah: not yet; it is experimental and they don’t release until we merge next into master

Mikeal: that seems bad

(General agreement that we want nan to release first.)

Trevor: looking at nan they seem to be working to encapsulate changes all the way out to V8 4.6.

Bert: what was the problem with putting nan into core?

Rod/Ben: sometimes V8 makes big changes that cause breaking changes in nan. E.g. isolates, buffer changes, maybes. Until now it’s been just individual APIs, but the 4.3 and 4.4 change has been very big. nan’s promise is just that you can write against a single, possibly-changing API that will support multiple node versions.

### Expose `deepEqual` and `deepStrictEqual` in `util`. #1172 [#1177](https://github.com/nodejs/io.js/pull/1177)

Jeremiah: what do we want to expose from core, there’s pressure from some parts of the community for core to be more isomorphic and support a lot of browser stuff. This issue is specifically about exposing what’s already implemented.

Ben: why not pull it out of core and put it in npm? util has always been about utilities that core uses.

Rod: when you expose something you’re stuck with it forever, minimising surface area should be our goal because the more we have to officially support the slower our release cycle will be.

### Proposal: Split TSC agenda in to two meetings [#1879](https://github.com/nodejs/io.js/issues/1879)

Mikeal: the scope of the TSC responsibilities are too wide, making meeting times go to long. The suggestion is to split up in to “project” related issues and “core” related issues.

Rod: can there be a clear distinction between the issues?

Domenic: assuming nobody wanted to attend two meetings, would there be enough?

Mikeal: yes because there are lots of people that aren’t here who would be in the other group

Rod: I wonder about the timing, e.g. letting the foundation kickoff happen first; it feels a bit premature to split now.

Mikeal: it’s a little premature but that’s because we haven’t onboarded the core working groups to this meeting.

Bert: in favour of the proposal.

_Discussed the pros and cons and agreed to tentatively move forward with experimentation, time slot for the new “project” meeting would either be after the current meeting or the day after that meeting._

### TSC needs to elect a board representative. [#1697](https://github.com/nodejs/io.js/issues/1697)

***Call ended prematurely due to Uberconference difficulties***

## Next meeting

*

Loading

0 comments on commit ddd72be

Please sign in to comment.