Skip to content

Commit 8fcaf34

Browse files
aduh95targosMylesBorinsTrottmmarchini
authored
Vote on primordials in error path (#1158)
* vote on primordials in the error path * vote from aduh95 * vote from targos * vote from MylesBorins * vote from Rich Trott * vote from Mary Marchini * vote from Matteo Collina * vote from Gireesh Punathil * vote from cjihrig * vote from jasnell * vote from Michael Dawson * vote from Robert Nagy * vote from RaisinTen * vote from RaisinTen * vote from RaisinTen * vote from Tobias Nießen * vote from richardlau * vote from richardlau * vote from Beth Griggs * vote from danielleadams * Add vote from Joyee Cheung * vote from BridgeAR * close vote and aggregate results * Add missing EOL * Add back Gireesh vote data Co-authored-by: Michaël Zasso <targos@protonmail.com> Co-authored-by: Myles Borins <mylesborins@github.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Co-authored-by: Mary Marchini <mmarchini@netflix.com> Co-authored-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Gireesh Punathil <gpunathi@in.ibm.com> Co-authored-by: cjihrig <cjihrig@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Michael Dawson <mdawson@devrus.com> Co-authored-by: Robert Nagy <ronagy@icloud.com> Co-authored-by: Darshan Sen <raisinten@gmail.com> Co-authored-by: Tobias Nießen <tniessen@tnie.de> Co-authored-by: Richard Lau <rlau@redhat.com> Co-authored-by: Beth Griggs <bgriggs@redhat.com> Co-authored-by: Danielle Adams <adamzdanielle@gmail.com> Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com> Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
1 parent d6d858d commit 8fcaf34

File tree

1 file changed

+157
-0
lines changed

1 file changed

+157
-0
lines changed

‎votes/2022-02-21-0.json

Lines changed: 157 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
1+
{
2+
"description": "Do we want to make code in the error path tamper proof (and how tamper proof do we want it to be)?",
3+
"refs": [
4+
"https://github.com/nodejs/TSC/pull/1158"
5+
],
6+
"outcome": {
7+
"winner(s)": [
8+
"Use primordials in the error path only if there are no significant perf regression."
9+
]
10+
},
11+
"votes": {
12+
"aduh95": {
13+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1,
14+
"Make the code in the error path full tamper proof by using primordials.": 2,
15+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1,
16+
"Use primordials in the error path only if there are no significant perf regression.": 0,
17+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
18+
"Don't use any primordials (and undo existing ones) in the error path.": -2
19+
},
20+
"BethGriggs": {
21+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 1,
22+
"Make the code in the error path full tamper proof by using primordials.": 1,
23+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
24+
"Use primordials in the error path only if there are no significant perf regression.": 3,
25+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3,
26+
"Don't use any primordials (and undo existing ones) in the error path.": 3
27+
},
28+
"BridgeAR": {
29+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
30+
"Make the code in the error path full tamper proof by using primordials.": 0,
31+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
32+
"Use primordials in the error path only if there are no significant perf regression.": 70,
33+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 80,
34+
"Don't use any primordials (and undo existing ones) in the error path.": 88
35+
},
36+
"cjihrig": {
37+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
38+
"Make the code in the error path full tamper proof by using primordials.": 0,
39+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
40+
"Use primordials in the error path only if there are no significant perf regression.": 0,
41+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
42+
"Don't use any primordials (and undo existing ones) in the error path.": 0
43+
},
44+
"danielleadams": {
45+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
46+
"Make the code in the error path full tamper proof by using primordials.": 0,
47+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
48+
"Use primordials in the error path only if there are no significant perf regression.": 0,
49+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
50+
"Don't use any primordials (and undo existing ones) in the error path.": 0
51+
},
52+
"gireeshpunathil": {
53+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 5,
54+
"Make the code in the error path full tamper proof by using primordials.": 3,
55+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 4,
56+
"Use primordials in the error path only if there are no significant perf regression.": 1,
57+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2,
58+
"Don't use any primordials (and undo existing ones) in the error path.": 0
59+
},
60+
"jasnell": {
61+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1,
62+
"Make the code in the error path full tamper proof by using primordials.": 0,
63+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
64+
"Use primordials in the error path only if there are no significant perf regression.": 0,
65+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1,
66+
"Don't use any primordials (and undo existing ones) in the error path.": -1
67+
},
68+
"joyeecheung": {
69+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3,
70+
"Make the code in the error path full tamper proof by using primordials.": 1,
71+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
72+
"Use primordials in the error path only if there are no significant perf regression.": 2,
73+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 2,
74+
"Don't use any primordials (and undo existing ones) in the error path.": 0
75+
},
76+
"mcollina": {
77+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
78+
"Make the code in the error path full tamper proof by using primordials.": 2,
79+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
80+
"Use primordials in the error path only if there are no significant perf regression.": 10,
81+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 3,
82+
"Don't use any primordials (and undo existing ones) in the error path.": 0
83+
},
84+
"mhdawson": {
85+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
86+
"Make the code in the error path full tamper proof by using primordials.": 0,
87+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
88+
"Use primordials in the error path only if there are no significant perf regression.": 5,
89+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
90+
"Don't use any primordials (and undo existing ones) in the error path.": 4
91+
},
92+
"mmarchini": {
93+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
94+
"Make the code in the error path full tamper proof by using primordials.": 0,
95+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
96+
"Use primordials in the error path only if there are no significant perf regression.": 0,
97+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
98+
"Don't use any primordials (and undo existing ones) in the error path.": 0
99+
},
100+
"MylesBorins": {
101+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
102+
"Make the code in the error path full tamper proof by using primordials.": 0,
103+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
104+
"Use primordials in the error path only if there are no significant perf regression.": 0,
105+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
106+
"Don't use any primordials (and undo existing ones) in the error path.": 0
107+
},
108+
"RaisinTen": {
109+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
110+
"Make the code in the error path full tamper proof by using primordials.": -1,
111+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
112+
"Use primordials in the error path only if there are no significant perf regression.": -1,
113+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1,
114+
"Don't use any primordials (and undo existing ones) in the error path.": 1
115+
},
116+
"richardlau": {
117+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 2,
118+
"Make the code in the error path full tamper proof by using primordials.": 0,
119+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
120+
"Use primordials in the error path only if there are no significant perf regression.": 1,
121+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
122+
"Don't use any primordials (and undo existing ones) in the error path.": 0
123+
},
124+
"ronag": {
125+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 3,
126+
"Make the code in the error path full tamper proof by using primordials.": 0,
127+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 1,
128+
"Use primordials in the error path only if there are no significant perf regression.": 2,
129+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 4,
130+
"Don't use any primordials (and undo existing ones) in the error path.": 5
131+
},
132+
"targos": {
133+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
134+
"Make the code in the error path full tamper proof by using primordials.": 3,
135+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 3,
136+
"Use primordials in the error path only if there are no significant perf regression.": 2,
137+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 1,
138+
"Don't use any primordials (and undo existing ones) in the error path.": 0
139+
},
140+
"tniessen": {
141+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": -1,
142+
"Make the code in the error path full tamper proof by using primordials.": 0,
143+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": -1,
144+
"Use primordials in the error path only if there are no significant perf regression.": 0,
145+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": -1,
146+
"Don't use any primordials (and undo existing ones) in the error path.": 0
147+
},
148+
"Trott": {
149+
"Make the code in the error path full tamper proof by porting it away from JS/main thread (while we are waiting for a PR doing this, primordials should be used).": 0,
150+
"Make the code in the error path full tamper proof by using primordials.": 0,
151+
"Make the code in the error path full tamper proof by using primordials + a build step to use bind-this proposal syntax.": 0,
152+
"Use primordials in the error path only if there are no significant perf regression.": 0,
153+
"Don't use primordials for prototype methods (and undo existing ones) in the error path, keep using them otherwise.": 0,
154+
"Don't use any primordials (and undo existing ones) in the error path.": 0
155+
}
156+
}
157+
}

0 commit comments

Comments
 (0)