Skip to content

Potential Semver Minor Backports #188

Closed
Closed
Potential Semver Minor Backports#188
Labels
backport-reviewlts-agenda

Description

@gibfahn
gibfahn
opened on Mar 17, 2017

Some more semver-minors to consider, now that #177 is closed.

Semver-minor v6.x backports:

I ran branch-diff --reverse --filter-release --require-label=semver-minor --exclude-label=semver-major,meta,dont-land-on-v6.x,backport-requested-to-v6.x up/v6.x up/v7.x

Not sure why it didn't include this (from the search query), maybe because the backport PR has do-not-land and didn't have semver-major, and the PR-URL was changed:

Backports

Yes

  • [570c5e1da8] - (SEMVER-MINOR) crypto: support OPENSSL_CONF again (Sam Roberts) #11006
  • [8be6702539] - (SEMVER-MINOR) src: add SafeGetenv() to internal API ( Sam Roberts) #11006
  • [08a7e7b009] - (SEMVER-MINOR) crypto: return this in setAuthTag/setAAD ( Kirill Fomichev) #9398
  • [ac2b059500] - (SEMVER-MINOR) crypto: do not use pointers to std::vector ( Adam Majer) #8334
  • [aeea13b6f6] - (SEMVER-MINOR) crypto: Use system CAs instead of using bundled ones ( Adam Majer) #8334
  • [a1897c1445] - (SEMVER-MINOR) crypto: ability to select cert store at runtime ( Adam Majer) #8334
  • [0a3e5cc57a] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve6() ( Ben Noordhuis) #9296
  • [1bd79368cd] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve4() ( Ben Noordhuis) #9296
  • [663c44eaaa] - (SEMVER-MINOR) cluster: return worker reference from disconnect() ( Sean Villars) #10019
  • [2096638fe0] - (SEMVER-MINOR) tls: allow obvious key/passphrase combinations ( Sam Roberts) #10294
  • [ecb3a7e933] - (SEMVER-MINOR) test: make tls-socket-default-options tests run ( Sam Roberts) #11005
  • [4e327708a9] - (SEMVER-MINOR) tls: new tls.TLSSocket() supports sec ctx options ( Sam Roberts) #11005
  • [d24491c6a7] - (SEMVER-MINOR) process: add NODE_NO_WARNINGS environment variable ( cjihrig) #10842
  • [92ed2b5001] - (SEMVER-MINOR) build: support for mips64el ( nanxiongchao) #10991
  • [8ab26cf508] - (SEMVER-MINOR) readline: add option to stop duplicates in history ( Danny Nemer) #2982
  • [ffd938a694] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.2 (cjihrig) #10717
    • [786631c7b4] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.1 (cjihrig) #9647
    • [106d71914c] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.0 (cjihrig) #9267

Manual

Consider for backporting:

Don't need backporting:

  • [3596d156c1] - (SEMVER-MINOR) lib: build node inspect into node ( Anna Henningsen) #10187
  • [85f54908bf] - (SEMVER-MINOR) deps: add node-inspect 1.10.2 (Jan Krems) #10187
  • [b1ef638de3] - (SEMVER-MINOR) src: default --icu_case_mapping on as a v8 option ( Steven R. Loomis) #9454
  • [8fdfa08ed0] - (SEMVER-MINOR) build: add node-inspect integration test (Jan Krems) #10187
  • [84e2ff3738] - (SEMVER-MINOR) doc: add basic documentation for WHATWG URL API (James M Snell) #10620
  • [614742b67f] - (SEMVER-MINOR) lib: deprecate node --debug at runtime ( Josh Gavant) #11275
  • [614742b67f] - (SEMVER-MINOR) lib: deprecate node --debug at runtime (Josh Gavant) #11275
  • [c92b8ecd81] - (SEMVER-MINOR) tools: add mdn link for Iterator ( James M Snell) #10620
  • [84e2ff3738] - (SEMVER-MINOR) doc: add basic documentation for WHATWG URL API ( James M Snell) #10620
  • [a5c62cb4f2] - (SEMVER-MINOR) readline: use icu based string width calculation ( James M Snell) #9040

Unsorted:

  • [1ee38eb874] - (SEMVER-MINOR) util: add %i and %f formatting specifiers ( Roman Reiss) #10308
  • [75f4329e01] - (SEMVER-MINOR) crypto: add randomFill and randomFillSync ( Evan Lucas) #10209

Activity

  1. mhdawson commented on Mar 20, 2017

    @mhdawson
    mhdawson
    on Mar 20, 2017
    Member

    I'm thinking one last one as it transitions to maintenance would make sense.

  2. sam-github commented on Mar 20, 2017

    @sam-github
    sam-github
    on Mar 20, 2017
    Contributor

    #8334 would probably be appreciated by the distros that use it, and which will be maintaining 4.x for some time, though they may be cherry picking the change anyhow.

    The tls, src, and http will make writing portable code across LTS versions much easier.

  3. italoacasas commented on Mar 20, 2017

    @italoacasas
    italoacasas
    on Mar 20, 2017

    Those commits have been living in v7.x for at least 4 weeks.

  4. gibfahn commented on Mar 21, 2017

    @gibfahn
    gibfahn
    on Mar 21, 2017
    MemberAuthor

    We also need to make sure we discuss the zlib update (nodejs/node#10980), see nodejs/node#10980 (comment)

  5. MylesBorins commented on Mar 22, 2017

    @MylesBorins
    MylesBorins
    on Mar 22, 2017
    Contributor

    I went ahead and landed the zlib updates in staging. I think them not landing was an oversight. If anyone can think of any reasons to pull it we can do so and discuss

  6. MylesBorins commented on Mar 22, 2017

    @MylesBorins
    MylesBorins
    on Mar 22, 2017
    Contributor

    Also worth mentioning we will not be doing any more minors on v4.x, so we can focus on v6.x

    edit: sorry for saying that in such a final way... didn't see above where you were posing that as a question to the group. I was under the impression after the last minor that we were not going to do any more for v4.x

    This can obviously be discussed if people see a reason to do so

    edit 2:

    I kinda just chimed in here without reading the comments from all of you in here regarding another minor for v4.x, not feeling great about the way I responded.

    To explain my point. We usually do a month long RC process for a minor, generally two weeks after the previous release, to allow for enough commits to collect.

    We just did a minor last month.

    Doing the proper cycle would bring us to May before we could release.

    We've had people bring up to us in the past that they want us to maintain our contract for releasing, I think the right thing to do is to properly move to maintenance, rather than doing a minor that is in my opinion a bit rushed.

  7. sam-github commented on Mar 23, 2017

    @sam-github
    sam-github
    on Mar 23, 2017
    Contributor

    If someone adds me to the repo I can edit - in the meantime, @gibfahn , can you add to 8334 a ref to it's 6.x backport: nodejs/node#11794

  8. gibfahn commented on Mar 28, 2017

    @gibfahn
    gibfahn
    on Mar 28, 2017
    MemberAuthor

    I'm not sure how patches to a maintenance v4.x get discussed, but it makes sense (at least to me) to raise them for discussion in the same way we currently discuss semver-minor backports to Active LTS.

    For example, I was looking through some old testcase failures, and I noticed that nodejs/node#10212 wasn't backported to v4.x. This is something we've seen fail quite a few times in v4.x, so it might be worth considering it for backporting.

  9. MylesBorins commented on Apr 24, 2017

    @MylesBorins
    MylesBorins
    on Apr 24, 2017
    Contributor

    @gibfahn do you want to update this list before the meeting tomorrow?

  10. gibfahn
    added
    lts-agenda
    on Apr 24, 2017

  11. jasnell commented on Apr 24, 2017

    @jasnell
    jasnell
    on Apr 24, 2017
    Member

    nodejs/node#11220 should not be backported to any LTS branch.

  12. jasnell commented on Apr 24, 2017

    @jasnell
    jasnell
    on Apr 24, 2017
    Member

    Nor should nodejs/node#10739

  13. sam-github commented on May 15, 2017

    @sam-github
    sam-github
    on May 15, 2017
    Contributor

    I missed end of meeting, but: #10209 might need baking, but should backport for consistency

  14. MylesBorins commented on May 15, 2017

    @MylesBorins
    MylesBorins
    on May 15, 2017
    Contributor

    @sam-github that was discussed and the conclusion in the meeting

  15. gibfahn commented on May 16, 2017

    @gibfahn
    gibfahn
    on May 16, 2017
    MemberAuthor

    @MylesBorins I think everything here is done and this can be closed now (reopen if you disagree...)

  16. gibfahn
    closed this as completedon May 16, 2017
  17. gibfahn
    added
    backport-review
    on Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    backport-reviewlts-agenda

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions