Skip to content
This repository was archived by the owner on Feb 29, 2020. It is now read-only.
This repository was archived by the owner on Feb 29, 2020. It is now read-only.

domainToASCII and domainToUnicode in intl #44

Closed
@watilde

Description

@watilde

Currently, we're using uidna_nameToASCII_UTF8 or uidna_nameToUnicodeUTF8 when users call domainToASCII or domainToUnicode with the url modules, but accoding to the specification it should be uidna_IDNToASCII and uidna_IDNToUnicode instead of them.

Then this test case doesn't work because of it. The inputs will be ., .. and 0..0x300 in this case.

How about adding the following methods into node_i18n to fix this issue?

  • binding('intl').IDNToASCII
  • binding('intl').IDNToUnicode

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions