This repository was archived by the owner on Feb 29, 2020. It is now read-only.
This repository was archived by the owner on Feb 29, 2020. It is now read-only.
domainToASCII and domainToUnicode in intl #44
Closed
Description
Currently, we're using uidna_nameToASCII_UTF8
or uidna_nameToUnicodeUTF8
when users call domainToASCII
or domainToUnicode
with the url
modules, but accoding to the specification it should be uidna_IDNToASCII
and uidna_IDNToUnicode
instead of them.
- https://url.spec.whatwg.org/#idna
- http://www.unicode.org/reports/tr46/#ToASCII
- http://www.unicode.org/reports/tr46/#ToUnicode
- http://icu-project.org/apiref/icu4c/uidna_8h.html#a711fa1d2e6dd25d7368f5b3ea2aaedc6
- http://icu-project.org/apiref/icu4c/uidna_8h.html#acf38e44019d4eb5a7dd903284fdb18e3
Then this test case doesn't work because of it. The inputs will be .
, ..
and 0..0x300
in this case.
How about adding the following methods into node_i18n
to fix this issue?
- binding('intl').IDNToASCII
- binding('intl').IDNToUnicode
Metadata
Metadata
Assignees
Labels
No labels