Skip to content

Fixes #25 Fix docs script #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2020
Merged

Fixes #25 Fix docs script #26

merged 2 commits into from
Oct 4, 2020

Conversation

michaeltintiuc
Copy link
Contributor

Fixes #25
Create a new script that handles all things docs related:

  • Used node's rmdirSync instead of rm -rf in order to have better cross-platform support
  • Move the generated array from guides.Interfaces to api.Interfaces
  • Delete api.Widgets array

shubhamzanwar
shubhamzanwar reviewed Oct 4, 2020
View reviewed changes
@shubhamzanwar
Copy link
Member

Thanks for this 🚀

@shubhamzanwar shubhamzanwar merged commit 0e5fdc4 into nodegui:master Oct 4, 2020
@michaeltintiuc michaeltintiuc deleted the 25-fix-docs-script branch October 4, 2020 14:39
@shubhamzanwar
Copy link
Member

@all-contributors please add @michaeltintiuc for Infrastructure

@allcontributors allcontributors bot mentioned this pull request Oct 4, 2020
Merged
@allcontributors
Copy link
Contributor

@shubhamzanwar

I've put up a pull request to add @michaeltintiuc! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamzanwar shubhamzanwar shubhamzanwar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write script to move autogenerated sidebar content to API.widgets from the Interfaces tab
2 participants
@michaeltintiuc @shubhamzanwar